Date: Tue, 23 Nov 2010 16:18:25 +0300 From: Sergey Kandaurov <pluknet@gmail.com> To: Marcel Moolenaar <xcllnt@mac.com> Cc: Alexander Best <arundel@freebsd.org>, freebsd-current@freebsd.org Subject: Re: old references to vfs_mountroot_try() Message-ID: <AANLkTimSuzLGUjHg=fogaYDt0ZaBJxbG5A0utaOT%2BB_4@mail.gmail.com> In-Reply-To: <6E2CBEBA-FFD7-4BBF-BFAD-192935040105@mac.com> References: <20101118231411.GA5121@freebsd.org> <AANLkTi=opRz6iP8_-KR9uM904KHRnR6NkDu6o75Uet%2Bv@mail.gmail.com> <6E2CBEBA-FFD7-4BBF-BFAD-192935040105@mac.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 19 November 2010 20:08, Marcel Moolenaar <xcllnt@mac.com> wrote: > > On Nov 19, 2010, at 2:09 AM, Sergey Kandaurov wrote: > >> On 19 November 2010 02:14, Alexander Best <arundel@freebsd.org> wrote: >>> hi there, >>> >>> vfs_mountroot_try() seems to have been removed, yet the src still conta= ins >>> three references to it: >>> >>> vfs_mount.c:386 >>> vfs_mount.c:723 >>> freebsd32_misc.c:2368 >>> >> >> So, what about just to rename those comments to reflect function name ch= ange? >> >> Index: sys/kern/vfs_mount.c >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> --- sys/kern/vfs_mount.c =A0 =A0 =A0 =A0(revision 215516) >> +++ sys/kern/vfs_mount.c =A0 =A0 =A0 =A0(working copy) >> @@ -383,7 +383,7 @@ >> =A0 =A0 =A0 =A0 * Filter out MNT_ROOTFS. =A0We do not want clients of nm= ount() in >> =A0 =A0 =A0 =A0 * userspace to set this flag, but we must filter it out = if we want >> =A0 =A0 =A0 =A0 * MNT_UPDATE on the root file system to work. >> - =A0 =A0 =A0 =A0* MNT_ROOTFS should only be set in the kernel in vfs_mo= untroot_try(). >> + =A0 =A0 =A0 =A0* MNT_ROOTFS should only be set in the kernel in parse_= mount(). >> =A0 =A0 =A0 =A0 */ >> =A0 =A0 =A0 =A0uap->flags &=3D ~MNT_ROOTFS; >> > > Keep it vague. Just change the line to "MNT_ROOTFS should only be > set by the kernel when mounting its root file system". > > The parse_mount() function name has no meaning other than within > sys/kern/vfs_mountroot.c, so referring to it isn't making things > clear. > Thanks for suggestion. I'm going to commit your version then. --=20 wbr, pluknet
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTimSuzLGUjHg=fogaYDt0ZaBJxbG5A0utaOT%2BB_4>