Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 29 Aug 2009 19:45:03 +0000 (UTC)
From:      Doug Barton <dougb@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org
Subject:   svn commit: r196645 - stable/8/etc
Message-ID:  <200908291945.n7TJj3vT073007@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: dougb
Date: Sat Aug 29 19:45:03 2009
New Revision: 196645
URL: http://svn.freebsd.org/changeset/base/196645

Log:
  MFC 196478:
  
  Prior to the dire warning about values of network_interfaces other than
  AUTO the biggest mistake users made was leaving lo0 off the list. Since
  lo0 is effectively mandatory, check for it and add it to the list if
  it's not there.
  
  MFC 196523:
  Improve the case test to detect the presence of lo0 in the list of
  network_interfaces.
  Submitted by:	Christoph Mallon <christoph.mallon@gmx.de>
  
  Approved by:	re (kib)

Modified:
  stable/8/etc/   (props changed)
  stable/8/etc/network.subr

Modified: stable/8/etc/network.subr
==============================================================================
--- stable/8/etc/network.subr	Sat Aug 29 18:01:02 2009	(r196644)
+++ stable/8/etc/network.subr	Sat Aug 29 19:45:03 2009	(r196645)
@@ -727,6 +727,13 @@ list_net_interfaces()
 		;;
 	*)
 		_tmplist="${network_interfaces} ${cloned_interfaces}"
+
+		# lo0 is effectively mandatory, so help prevent foot-shooting
+		#
+		case "$_tmplist" in
+		lo0|'lo0 '*|*' lo0'|*' lo0 '*) ;; # This is fine, do nothing
+		*)	_tmplist="lo0 ${_tmplist}" ;;
+		esac
 		;;
 	esac
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200908291945.n7TJj3vT073007>