Date: Tue, 23 Nov 1999 22:57:50 -0800 From: "David O'Brien" <obrien@NUXI.com> To: Kris Kennaway <kris@hub.freebsd.org> Cc: current@freebsd.org Subject: Re: Overflow in banner(1) Message-ID: <19991123225750.F49362@dragon.nuxi.com> In-Reply-To: <Pine.BSF.4.21.9911232250140.13236-100000@hub.freebsd.org>; from kris@hub.freebsd.org on Tue, Nov 23, 1999 at 10:51:11PM -0800 References: <19991123224424.B51939@dragon.nuxi.com> <Pine.BSF.4.21.9911232250140.13236-100000@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> > > - (void)fgets(message, sizeof(message), stdin); > > > + (void)fgets(message, MAXMSG, stdin); > > > > There is nothing wrong with the original line here. Please don't change > > things that are fine just to change them. We don't want to ofuscate > > Obviously not, but I didn't see the point in making it inconsistent. You could make the "MAXMSG" you added "sizeof(message)" and been consistent. :) -- -- David (obrien@NUXI.com) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19991123225750.F49362>