Date: Mon, 24 Nov 2014 14:02:06 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 195333] New: Inconsistent handling of ALL_TARGET, INSTALL_TARGET by options framework Message-ID: <bug-195333-13@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=195333 Bug ID: 195333 Summary: Inconsistent handling of ALL_TARGET, INSTALL_TARGET by options framework Product: Ports Tree Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: Infrastructure Assignee: freebsd-ports-bugs@FreeBSD.org Reporter: amdmi3@FreeBSD.org There's ALL_TARGET?= all INSTALL_TARGET?= install INSTALL_TARGET+= ${LATE_INSTALL_ARGS} block in bsd.port.mk (line 2263), and it is located after bsd.options.mk inclusion (line 1343). This leads to inconsistent handling of ALL_TARGET, INSTALL_TARGET by options framework: while documentation and code suggest that OPTIONS_DEFINE=FOO FOO_ALL_TARGET=foo should append foo to ALL_TARGET, it overrides ALL_TARGET instead. If there are multiple options which define ${opt}_ALL_TARGET, first one will override the variable and others will append. To fix this, above mentioned block should be moved before bsd.options.mk inclusion. Some ports may rely on old behavior, so they need to be checked. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-195333-13>