Date: Thu, 5 Dec 2013 11:07:39 +0100 From: Kajetan Staszkiewicz <vegeta@tuxpowered.net> To: Gleb Smirnoff <glebius@freebsd.org> Cc: "freebsd-pf@freebsd.org" <freebsd-pf@freebsd.org> Subject: Re: [patch] Source entries removing is awfully slow. Message-ID: <201312051107.39932.vegeta@tuxpowered.net> In-Reply-To: <20131205081848.GQ48919@glebius.int.ru> References: <201303081419.17743.vegeta@tuxpowered.net> <201312041529.21788.vegeta@tuxpowered.net> <20131205081848.GQ48919@glebius.int.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
Dnia czwartek, 5 grudnia 2013 o 09:18:48 Gleb Smirnoff napisa=C5=82(a): > K> To have the most clean and simple code it would make the most sense to > use the K> aforementioned pfioc_universal_kill for both DIOCKILLSTATES and > K> DIOCKILLSRCNODES. But that would be a change of kernel api which I > assume can K> not take place inside major release, so translation of > structures is currently K> the way to go. Please correct me if I am wrong. >=20 > It is okay to add new API. I was rather thinking about leaving DIOCKILLSTATES and DIOCKILLSRCNODES ioc= tls=20 in place but change the structure passed to them to pfioc_universal_killer.= So=20 changint the existing API. > So in head we will add new API/ABI, then remove obsoleted one. We will > merge only addition to stable/10, not removal. >=20 > The ABI constraints for stable branches are the following. Newer kernel > must work with older utilxities. So, 10.1 kernel will work with pfctl from > 10.0, since old ioctls are still supported. Is recompiling older utilities allowed? Please note that I need to add=20 ps(n?)k_table to (pfioc_src_nod|stat)e_kill and psnk_killed_states to=20 psnk_src_node_kill anyway. If not, then we must consider that this patch co= uld=20 get only into head, and only with struct pfioc_universal_kill. I see no rea= son=20 to clean up the old parser without adding the new syntax with new parameter= s. =2D-=20 | pozdrawiam / greetings | powered by Debian, FreeBSD and CentOS | | Kajetan Staszkiewicz | jabber,email: vegeta()tuxpowered net | | Vegeta | www: http://vegeta.tuxpowered.net | `------------------------^---------------------------------------'
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201312051107.39932.vegeta>