Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 7 Mar 2014 13:09:04 GMT
From:      Trond Endrestøl <Trond.Endrestol@ximalas.info>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/187349: print/xdvik/Makefile wrongfully assumes ${WRKSRC}/pkg-install is created with execute permission
Message-ID:  <201403071309.s27D944T035725@cgiserv.freebsd.org>
Resent-Message-ID: <201403071310.s27DA1p3069603@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         187349
>Category:       ports
>Synopsis:       print/xdvik/Makefile wrongfully assumes ${WRKSRC}/pkg-install is created with execute permission
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Mar 07 13:10:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Trond Endrestøl
>Release:        FreeBSD 9.2-STABLE
>Organization:
Private
>Environment:
FreeBSD enterprise.ximalas.info 9.2-STABLE FreeBSD 9.2-STABLE #0 r262730: Tue Mar  4 14:46:38 CET 2014     root@enterprise.ximalas.info:/usr/obj/usr/src/sys/ENTERPRISE  amd64
>Description:
print/xdvik/Makefile wrongfully assumes ${WRKSRC}/pkg-install is created with execute permission.


>How-To-Repeat:
cd /usr/ports/print/xdvik && make install
>Fix:
I've created two patches. The first one turns on the execute permission, the second implicitly runs pkg-install through /bin/sh. (Whitespace is doomed to be lost below, type manually if you choose to use either patch.)

--- Makefile.orig       2014-03-06 20:03:59.625349000 +0100
+++ Makefile    2014-03-07 13:55:38.618351079 +0100
@@ -77,6 +77,7 @@
        ${MKDIR} ${DOCSDIR}
        cd ${WRKSRC} && ${INSTALL_DATA} ${PORTDOCS} ${DOCSDIR}
 .endif
+       chmod a+x ${PKGINSTALL}
        @${PKGINSTALL} ${PKGNAME} POST-INSTALL

 .include <bsd.port.mk>


--- Makefile.orig       2014-03-06 20:03:59.625349000 +0100
+++ Makefile    2014-03-07 13:57:13.697351814 +0100
@@ -77,6 +77,6 @@
        ${MKDIR} ${DOCSDIR}
        cd ${WRKSRC} && ${INSTALL_DATA} ${PORTDOCS} ${DOCSDIR}
 .endif
-       @${PKGINSTALL} ${PKGNAME} POST-INSTALL
+       @/bin/sh ${PKGINSTALL} ${PKGNAME} POST-INSTALL

 .include <bsd.port.mk>


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201403071309.s27D944T035725>