Date: Fri, 1 Nov 2002 12:07:05 -0800 (PST) From: Nate Lawson <nate@root.org> To: Brooks Davis <brooks@one-eyed-alien.net> Cc: hackers@freebsd.org Subject: Re: [PATCH] switching to if_xname Message-ID: <Pine.BSF.4.21.0211011156360.97230-100000@root.org> In-Reply-To: <20021101105423.A9676@Odin.AC.HMC.Edu>
next in thread | previous in thread | raw e-mail | index | archive | help
You might also try -net or -arch. On Fri, 1 Nov 2002, Brooks Davis wrote: > I'm trying to get some review for the following patch. I realize it's > quite large, but most it is is trivial. The ipfw code is the only thing > that worries me significantly. I have promised Kris that I will fix > ports that break with this change so you don't need to worry about that > issue. > > I'd like to commit this prior to 5.0-R pending RE approval (post DP2 > would be fine if that would help get it out the door). > > Thanks, > Brooks > > http://people.freebsd.org/~brooks/patches/if_xname.diff > > Please review. Couple comments. * You interchangeably use strlcpy and snprintf(... "%s", ...) and even strncpy/strcpy(!). You probably want to go with just strlcpy. * There may be some cases where a string compare is too slow and it needs a unit compare. I'm not familiar with the code that does this but please comment. * Some places seem to still be using a unit number as a local loop counter. Just curious if this has any side effects. * Do the ipfw glob changes break ABI? Overall, I like it. -Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0211011156360.97230-100000>