Date: Tue, 30 Mar 2004 23:35:16 -0800 From: Peter Wemm <peter@wemm.org> To: freebsd-amd64@freebsd.org Subject: HEADS UP: cvs commit: src/lib/libc/amd64/gen makecontext.c signalcontext.c Message-ID: <200403302335.16357.peter@wemm.org>
next in thread | raw e-mail | index | archive | help
I've found another stack alignment bug. This one is an easy fix, it
just needs a libc rebuild/install.
Can I get a sanity check from the folks who can break ogg123? I
actually found this using ogg123 in case you're interested.
---------- Forwarded Message ----------
Subject: cvs commit: src/lib/libc/amd64/gen makecontext.c
signalcontext.c
Date: Tuesday 30 March 2004 11:27 pm
From: Peter Wemm <peter@FreeBSD.org>
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
peter 2004/03/30 23:27:31 PST
FreeBSD src repository
Modified files:
lib/libc/amd64/gen makecontext.c signalcontext.c
Log:
Fix Yet Another 16 byte stack alignment bug. Thankfully, this one is
solved by a simple 'make world'. The signalcontext function was
going to the trouble of generating an even 16 byte alignment, but in
fact it needed to be odd aligned to simulate the 8-byte return address
having been pushed by the caller. This fixes yet another group of
crashes in applications using libpthread. And yet again, it was my
fault all along.
While here, rename the duplicate internal ctx_wrapper() functions to
makectx_wrapper() and sigctx_wrapper() so that traces aren't
ambiguous.
Revision Changes Path
1.3 +3 -3 src/lib/libc/amd64/gen/makecontext.c
1.3 +7 -7 src/lib/libc/amd64/gen/signalcontext.c
-------------------------------------------------------
--
Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com
"All of this is for nothing if we don't go to the stars" - JMS/B5
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200403302335.16357.peter>