Date: Sat, 20 Oct 2007 21:25:40 +0200 From: Max Laier <max@love2party.net> To: freebsd-current@freebsd.org Cc: ports@freebsd.org, Norikatsu Shigemura <nork@freebsd.org> Subject: Re: new imported libpcap has net/bpf.h handling issue Message-ID: <200710202125.50278.max@love2party.net> In-Reply-To: <20071021033505.48fec4a7.nork@FreeBSD.org> References: <20071021033505.48fec4a7.nork@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart7961610.jzLCfHT4SY Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Saturday 20 October 2007, Norikatsu Shigemura wrote: > I tried to install ports/net/pchar on 8-current machine. And > I got following compiling error message:-(. > > c++ -O -fno-strict-aliasing -pipe -march=3Dpentium3 -I. -DSIZEOF_BOOL=3D1 > -DHAVE_SOCKLEN_T=3D1 -DSTDC_HEADERS=3D1 -DHAVE_UNISTD_H=3D1 > -DHAVE_STRINGS_H=3D1 -DHAVE_SOCKADDR_SA_LEN=3D1 -DHAVE_HERROR=3D1 > -DHAVE_SNPRINTF=3D1 -DHAVE_LIBM=3D1 -DHAVE_IPV6=3D1 -DHAVE_PCAP=3D1 > -DHAVE_LIBPCAP=3D1 -DHAVE_BPF=3D1 -c Pctest.cc -o Pctest.o Pctest.cc: In > constructor 'Pctest::Pctest()': > Pctest.cc:103: error: 'BIOCIMMEDIATE' was not declared in this scope > > So I research this issue. As the result, I found a issue which > is that new pcap.h doesn't #include <net/bpf.h>. > > I don't have any idea to fix this issue. Anyone, please fix > this issue:-). I'm somewhat reluctant to apply this as I don't think it's a good idea to=20 have that kind of namespace pollution in the pcap header. If you want to=20 use bpf directly, you should include the header yourself. As this behavior is verbatim from the vendor, code that doesn't include=20 sys/bpf.h when it needs it isn't portable and should be fixed, anyhow. This of course is just my reading of things and you can convince me=20 otherwise. If a ton of ports break, we most certainly should apply the=20 bandaid. > --- src/contrib/libpcap/pcap.h 2006/09/04 19:54:21 1.12 > +++ src/contrib/libpcap/pcap.h 2007/10/16 02:07:55 1.13 > @@ -32,7 +32,7 @@ > * SUCH DAMAGE. > * > * $FreeBSD$ > - * @(#) $Header: /home/ncvs/src/contrib/libpcap/pcap.h,v 1.12 > 2006/09/04 19:54:21 sam Exp $ (LBL) + * @(#) $Header: > /home/ncvs/src/contrib/libpcap/pcap.h,v 1.13 2007/10/16 02:07:55 mlaier > Exp $ (LBL) */ > > #ifndef lib_pcap_h > @@ -41,7 +41,9 @@ > #include <sys/types.h> > #include <sys/time.h> > > -#include <net/bpf.h> > +#ifndef PCAP_DONT_INCLUDE_PCAP_BPF_H > +#include <pcap-bpf.h> > +#endif > > #include <stdio.h> =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --nextPart7961610.jzLCfHT4SY Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQBHGlY+XyyEoT62BG0RAp3nAJ44oZVRE0RDf5mIDo23j4b/mBvxfQCePPhj VI6uDdr3beua2oF4NaS4J3E= =4LsI -----END PGP SIGNATURE----- --nextPart7961610.jzLCfHT4SY--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200710202125.50278.max>