Date: Mon, 18 Jun 2007 14:06:45 GMT From: Rui Paulo <rpaulo@FreeBSD.org> To: Perforce Change Reviews <perforce@FreeBSD.org> Subject: PERFORCE change 121914 for review Message-ID: <200706181406.l5IE6j4C007648@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=121914 Change 121914 by rpaulo@rpaulo_epsilon on 2007/06/18 14:06:34 Move the usb quirk check a little above to avoid a memory leak. Affected files ... .. //depot/projects/soc2007/rpaulo-macbook/dev/usb/ums.c#9 edit Differences ... ==== //depot/projects/soc2007/rpaulo-macbook/dev/usb/ums.c#9 (text+ko) ==== @@ -169,6 +169,9 @@ void *desc; usbd_status err; + if (usbd_get_quirks(uaa->device)->uq_flags & UQ_MS_IGNORE) + return (UMATCH_NONE); + if (!uaa->iface) return (UMATCH_NONE); id = usbd_get_interface_descriptor(uaa->iface); @@ -179,9 +182,6 @@ if (err) return (UMATCH_NONE); - if (usbd_get_quirks(uaa->device)->uq_flags & UQ_MS_IGNORE) - return (UMATCH_NONE); - if (hid_is_collection(desc, size, HID_USAGE2(HUP_GENERIC_DESKTOP, HUG_MOUSE))) ret = UMATCH_IFACECLASS;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200706181406.l5IE6j4C007648>