Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 27 Dec 2009 22:50:26 +0000 (UTC)
From:      Matt Jacob <mjacob@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org
Subject:   svn commit: r201068 - stable/8/sys/dev/ips
Message-ID:  <200912272250.nBRMoQgs070025@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mjacob
Date: Sun Dec 27 22:50:25 2009
New Revision: 201068
URL: http://svn.freebsd.org/changeset/base/201068

Log:
  MFC of 198329: Check pointer for NULL before dereferencing it, not after.

Modified:
  stable/8/sys/dev/ips/ips_disk.c

Modified: stable/8/sys/dev/ips/ips_disk.c
==============================================================================
--- stable/8/sys/dev/ips/ips_disk.c	Sun Dec 27 22:49:34 2009	(r201067)
+++ stable/8/sys/dev/ips/ips_disk.c	Sun Dec 27 22:50:25 2009	(r201068)
@@ -192,10 +192,10 @@ ipsd_dump(void *arg, void *virtual, vm_o
 
 	dp = arg;
 	dsc = dp->d_drv1;
-	sc = dsc->sc;
 
 	if (dsc == NULL)
 		return (EINVAL);
+	sc = dsc->sc;
 
 	if (ips_get_free_cmd(sc, &command, 0) != 0) {
 		printf("ipsd: failed to get cmd for dump\n");



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200912272250.nBRMoQgs070025>