Date: Wed, 18 Aug 1999 09:19:20 -0400 (EDT) From: "Mark J. Taylor" <mtaylor@cybernet.com> To: Greg Lehey <grog@lemis.com> Cc: Sheldon Hearn <sheldonh@uunet.co.za>, Poul-Henning Kamp <phk@critter.freebsd.dk>, current@FreeBSD.ORG Subject: Re: ccd bugs (was: Kernel hacker tasks seek interested hackers) Message-ID: <Pine.BSF.4.01.9908180909230.11820-100000@gateway.cybernet.com> In-Reply-To: <19990818083935.L7187@freebie.lemis.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This may be related: There is a long as a parameter to ccdbuffer that needs to be a u_long. Otherwise, you'll get panics (can't remember where). Basically, bcount needs to be a u_long in all cases. I haven't gotten around, because of the NetMAX for Linux project, to comitting things like this to the FreeBSD project. -Mark Taylor NetMAX Developer mtaylor@cybernet.com http://www.netmax.com/ Patches relative to FreeBSD 3.2-RELEASE. Pine probably botched the formatting, so do this by hand. *** ccd.c 1999/07/17 00:15:53 1.1 --- ccd.c 1999/07/22 04:03:37 1.2 *************** *** 199,201 **** static void ccdbuffer __P((struct ccdbuf **ret, struct ccd_softc *, ! struct buf *, daddr_t, caddr_t, long)); static void ccdgetdisklabel __P((dev_t)); --- 199,201 ---- static void ccdbuffer __P((struct ccdbuf **ret, struct ccd_softc *, ! struct buf *, daddr_t, caddr_t, u_long)); static void ccdgetdisklabel __P((dev_t)); *************** *** 767,769 **** { ! register long bcount, rcount; struct ccdbuf *cbp[4]; --- 767,769 ---- { ! register u_long bcount, rcount; struct ccdbuf *cbp[4]; *************** *** 822,824 **** caddr_t addr; ! long bcount; { --- 822,824 ---- caddr_t addr; ! u_long bcount; { On Wed, 18 Aug 1999, Greg Lehey wrote: > On Tuesday, 17 August 1999 at 10:28:34 +0200, Sheldon Hearn wrote: > > > > > > On Sun, 15 Aug 1999 12:27:57 +0200, Poul-Henning Kamp wrote: > > > >> 4. [not quite easy] The CCD device ditto. > >> Earn brownie points: Make ccdconfig use sysctl instead of > >> libkvm to read back configuration. > > > > Anyone who decides to tackle this one is likely to have the wherewithall > > to test a PR which I can't right now -- PR 10077: > > > > PR: 10077 > > Class: kern > > Synopsis: dd'ing a ccd stripped partition sometimes hangs in physstr > > Don't count on it. He's talking serious disk space (starting at 8 GB > on two disks). > > Why did you take this one? It's certainly not a dd problem. I'd > guess that it's a numeric overflow problem; there have been other such > problems in ccd before. > > Greg > -- > See complete headers for address, home page and phone numbers > finger grog@lemis.com for PGP public key > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-current" in the body of the message > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.01.9908180909230.11820-100000>