Date: Tue, 05 Mar 2013 15:13:12 +0100 From: =?ISO-8859-1?Q?Jean-S=E9bastien_P=E9dron?= <dumbbell@FreeBSD.org> To: freebsd-current@freebsd.org Cc: Konstantin Belousov <kostikbel@gmail.com>, "J.R. Oldroyd" <jr@opal.com> Subject: Re: r247835: drm2 code breaks buildkernel Message-ID: <5135FD78.1050608@FreeBSD.org> In-Reply-To: <20130305123016.GE1483@glenbarber.us> References: <5135C70B.50906@zedat.fu-berlin.de> <5135CD0E.8040801@dumbbell.fr> <5135DE36.9010303@zedat.fu-berlin.de> <20130305123016.GE1483@glenbarber.us>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
------enig2GVGBTWFPHBEOUGDKEESL
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
On 05.03.2013 13:30, Glen Barber wrote:
> dev/drm2/ttm/ttm_lock.h:208: warning: redundant redeclaration of 'ttm_w=
rite_unlock' [-Wredundant-decls]
> dev/drm2/ttm/ttm_lock.h:134: warning: previous declaration of 'ttm_writ=
e_unlock' was here
> dev/drm2/ttm/ttm_lock.h:220: warning: redundant redeclaration of 'ttm_w=
rite_lock' [-Wredundant-decls]
> dev/drm2/ttm/ttm_lock.h:146: warning: previous declaration of 'ttm_writ=
e_lock' was here
Those redundant declarations weren't spotted by clang.
Konstantin, would you like me to commit the fix for this? And we need to
upstream it too.
> dev/drm2/ttm/ttm_page_alloc.c:122: warning: declaration does not declar=
e anything
> dev/drm2/ttm/ttm_page_alloc.c:123: warning: declaration does not declar=
e anything
These errors and the following are caused by unnamed structs and unions
inside another struct:
struct ttm_pool_manager {
...
union {
struct ttm_page_pool pools[NUM_POOLS];
struct {
...
} ;
};
};
With default options, clang accepts this but apparently, not gcc.
I would like an opinion from the toolchain gurus, because I don't know
what's the proper way to fix this one.
J.R. Oldroyd CC'd, because he started to work on radeonkms backport to 9
and faced exactly those issues.
--=20
Jean-S=E9bastien P=E9dron
------enig2GVGBTWFPHBEOUGDKEESL
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iEYEARECAAYFAlE1/XgACgkQa+xGJsFYOlPPqwCgljpm8HOWKYCEodHzUpvhrsO9
8igAoM0eXDzZ/ad7y2+uGumDvI63LFgx
=SyCJ
-----END PGP SIGNATURE-----
------enig2GVGBTWFPHBEOUGDKEESL--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5135FD78.1050608>