Date: Mon, 24 Oct 2011 16:50:03 GMT From: Ruslan Mahmatkhanov <cvs-src@yandex.ru> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/161963: [MAINTAINER] net-p2p/py26-BitTornado: [SUMMARIZE CHANGES] Message-ID: <201110241650.p9OGo3pv049650@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/161963; it has been noted by GNATS. From: Ruslan Mahmatkhanov <cvs-src@yandex.ru> To: Mohacsi Janos <janos.mohacsi@bsd.hu> Cc: FreeBSD-gnats-submit@FreeBSD.org Subject: Re: ports/161963: [MAINTAINER] net-p2p/py26-BitTornado: [SUMMARIZE CHANGES] Date: Mon, 24 Oct 2011 20:44:58 +0400 Mohacsi Janos wrote on 24.10.2011 20:04: > On 10/24/11 16:12, Ruslan Mahmatkhanov wrote: >> >>> -WX_COMPS= python >>> +WX_COMPS= ${PYTHON_CMD} >> >> Hi, Janos. >> >> This change is wrong. "WX_COMPS=python" means that this port needs >> x11-toolkits/wxPython28 port for building/running. Please see >> Mk/bsd.wx.mk. This need to be fixed. >> > You are right. After fixing the port I check the port with the portlint > tool. portlint suggested changing the python to ${PYTHON_CMD}. I > accepted it without checking the consequences. Please remove this > changes from the Makefile. Should I send a new patch? > > Best Regards, > Janos Mohacsi Yes, understood. Portlint failing on this one too often. I can't fix anything, sorry, i'm not a committer, but sure it will be better if you resend corrected patch. -- Regards, Ruslan Tinderboxing kills... the drives.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201110241650.p9OGo3pv049650>