Date: Sun, 12 Dec 2004 16:13:53 -0800 From: Julian Elischer <julian@elischer.org> To: Scott Mitchell <scott+freebsd@fishballoon.org> Cc: Julian Elischer <julian@freebsd.org> Subject: Re: cvs commit: src/sys/sys mouse.h src/sys/dev/usb ums.c usbhid.h Message-ID: <41BCDEC1.4000009@elischer.org> In-Reply-To: <20041212142640.GF68019@tuatara.fishballoon.org> References: <20041212133752.GE68019@tuatara.fishballoon.org> <200412121411.aa89799@salmon.maths.tcd.ie> <20041212142640.GF68019@tuatara.fishballoon.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Scott Mitchell wrote: > On Sun, Dec 12, 2004 at 02:11:22PM +0000, Ian Dowse wrote: > >>In message <20041212133752.GE68019@tuatara.fishballoon.org>, Scott Mitchell wri >>tes: >> >>>On Sun, Dec 12, 2004 at 12:23:05PM +0000, Ceri Davies wrote: >>> >>>>On Sat, Dec 11, 2004 at 10:39:10PM -0700, Scott Long wrote: >>>> >>>>>Julian Elischer wrote: >>>>> >>>>>> Add support for USB Microsoft Intellimouse >>>>>> >>>>>> PR: kern/70607 >>>>>> Submitted by: Matt Wright <matt@consultmatt.co.uk> >>>>>> MFC after: 1 week >>>>> >>>>>What 'support' does this add? >>>> >>>>They have another axis on the wheel: you can tilt it from left to right. >>>> >>>>Ceri >>> >>>Apart from that, the device in question (wireless Intellimouse 2.0) didn't >>>work as any kind of mouse without this patch. >>> >>> Scott >> >>As pointed out in the PR though, it doesn't seem necessary to change >>struct mousestatus and the MOUSE_GETSTATUS ioctl API just to make >>the device work. All other mouse drivers in the tree will need to >>be updated to initialise the new `dt' field. There's also one part >>of the patch that looks as if it could easily break other devices: > > > Ahhh, my bad. I'd read the PR and thought it was the last version > mentioned by marko@ (without the mousestatus change) that had been > committed. Although now that I look a bit closer I can't actually find > that version anywhere. > > I'll shut up now. > > Scott > uh my bad.. I THOUGHT I had committed the last version, as I got it from the URL he supplied as being the last one.. I'll look around to see if there is a newer one, or try fix this one..
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?41BCDEC1.4000009>