Date: Sun, 29 Jul 2007 21:58:10 +0000 (UTC) From: "Bjoern A. Zeeb" <bz@FreeBSD.org> To: mjacob@freebsd.org Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netinet tcp_input.c tcp_usrreq.c Message-ID: <20070729214715.I31116@maildrop.int.zabbadoz.net> In-Reply-To: <20070729143653.E86313@ns1.feral.com> References: <200707290131.l6T1VY8g026872@repoman.freebsd.org> <46AC987A.9040501@freebsd.org> <20070729184123.S44136@mp2.macomnet.net> <20070729095743.N84864@ns1.feral.com> <20070729101357.A84864@ns1.feral.com> <20070729101935.D84864@ns1.feral.com> <20070729211359.C31116@maildrop.int.zabbadoz.net> <20070729143653.E86313@ns1.feral.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 29 Jul 2007, mjacob@freebsd.org wrote: Hi, > On Sun, 29 Jul 2007, Bjoern A. Zeeb wrote: > >> On Sun, 29 Jul 2007, mjacob@freebsd.org wrote: >> >>> Here's what probably works. I'll do the test compiles. >> >> If I am not wrong it will not. >> >> The follwoing two files have comments at the beginning to explain the >> changes. >> I don't like the extern char *tcpstates[] but it seems to be the best >> solution for now. > > No, that's what's actually wrong. tcpstates has to be static to honor the > intent of the original author. If you want to do something extern then the > actual tcpstates should go into tcp_debug.c. However, this is slightly less > flexible in that the way it is now each source file can include this array > simply by defining TCPSTATES (independent of TCPDEBUG as an option). It should go int tcp_input.c if any because that's the only file that always needs it now. If you do not have TCP there will be no tcp_input and TCPDEBUG will make no sense but there can be a tcp_input without TCPDEBUG/tcp_debug. It has been used with the extern in netipx since 1995. It is exposed to user space so moving it out of the header will break things. If you have any other better short term solution to not break anything I am happy but I could not see one. As said, I am not happy with the extern either. -- Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT Software is harder than hardware so better get it right the first time.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070729214715.I31116>