Date: Tue, 29 Feb 2000 18:37:07 +1030 From: Greg Lehey <grog@lemis.com> To: Alfred Perlstein <bright@wintelcom.net> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/vinum vinumrequest.c Message-ID: <20000229183706.D16629@freebie.lemis.com> In-Reply-To: <20000229002459.B21720@fw.wintelcom.net> References: <200002290614.WAA16809@freefall.freebsd.org> <20000229002459.B21720@fw.wintelcom.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday, 29 February 2000 at 0:25:00 -0800, Alfred Perlstein wrote: > * Greg Lehey <grog@FreeBSD.org> [000228 22:45] wrote: >> grog 2000/02/28 22:14:45 PST >> >> Modified files: >> sys/dev/vinum vinumrequest.c >> Log: >> launch_requests: If too many requests are active, include PCATCH in >> the tsleep call flags. >> >> Submitted-by: Bernd Walter <ticso@cicely.de> > > grrr! > > while ((drive->active >= DRIVE_MAXACTIVE) /* it has too much to do already, */ >>> (vinum_conf.active >= VINUM_MAXACTIVE)) /* or too many requests globally */ > - tsleep(&launch_requests, PRIBIO, "vinbuf", 0); /* wait for it to subside */ > + tsleep(&launch_requests, PRIBIO | PCATCH, "vinbuf", 0); /* wait for it to subside */ > drive->active++; > > please back this out, i've already fixed this twice, if you actually > get a signal you'll spin in the kernel. > > the correct solution must check the return from tsleep and actually > do something with an error return, for now we've agreed to ignore > signals until a safe return can be implemented. PCATCH must be > removed. OK, make a suggestion. The trouble is, you and Bernd keep asking for opposite things, and I was getting out of phase on the whole matter. In any case, another change I made (MAXREQUESTS = 30000) means that we'll never call tsleep here. Greg -- Finger grog@lemis.com for PGP public key See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000229183706.D16629>