Date: Sat, 13 Aug 2016 22:51:59 -0700 From: Conrad Meyer <cem@freebsd.org> To: Juli Mallett <juli@clockworksquid.com> Cc: Glen Barber <gjb@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-svnadmin@freebsd.org, svnadm@freebsd.org Subject: Re: svn commit: r304070 - svnadmin/conf Message-ID: <CAG6CVpVHaGH-%2Bh9%2B%2BfZiBRzdghiecpoX6WcRTxfdaY2iVoB%2BrQ@mail.gmail.com> In-Reply-To: <CACVs6=-HUP=Mwt6%2Bu3epDHfOF4L2mibTvdN0fyc3bbOeC4%2Bj8g@mail.gmail.com> References: <201608140435.u7E4Z4Fm022554@repo.freebsd.org> <CAG6CVpXoAtpEva0=H-tLtJLnk2gDRo-8=0cRuV7jghXdJq8fyw@mail.gmail.com> <20160814044723.GF11079@FreeBSD.org> <CACVs6=-HUP=Mwt6%2Bu3epDHfOF4L2mibTvdN0fyc3bbOeC4%2Bj8g@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Aug 13, 2016 at 10:48 PM, Juli Mallett <juli@clockworksquid.com> wrote: > On Sat, Aug 13, 2016 at 9:47 PM, Glen Barber <gjb@freebsd.org> wrote: >> Quoting the original request to remove this, which I tend to agree: >> >> -------------------------- begin quoted text --------------------------- >> The svn commit mail script uses some form of 'diff -p' (or 'svn diff >> -x-p') to include function names at the top of each hunk. The problem >> is that diff gets it wrong more often than not, especially (but not >> only) when functions are added or renamed, or outside a funciton, or in >> headers, or in code that makes heavy use of macros, or in files that >> aren't C-like source code: shell scripts, man pages, Makefiles... All >> it really does is clutter up the patch and mislead the reader. >> --------------------------- end quoted text ---------------------------- > > :( > > I'm deeply skeptical that the described conditions add up to "more > often than not," and that tangible harm is done in those cases, > outweighing benefit added in the other, ostensibly rarer, case > (changes in ordinary C source files, which are actually fairly > abundant in FreeBSD.) Exactly. Yes, it gets it wrong sometimes. But not enough to make it more harmful than beneficial. Best, Conrad
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpVHaGH-%2Bh9%2B%2BfZiBRzdghiecpoX6WcRTxfdaY2iVoB%2BrQ>