Date: Mon, 18 May 2015 09:41:06 -0700 From: Garrett Cooper <yaneurabeya@gmail.com> To: Ian Lepore <ian@freebsd.org> Cc: Mathieu Arnold <m@absolight.fr>, Eitan Adler <eadler@freebsd.org>, "phabric-admin@freebsd.org" <phabric-admin@freebsd.org>, Adrian Chadd <adrian@freebsd.org>, Zbigniew Bodek <zbb@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r282985 - in head/sys: arm/annapurna arm/annapurna/alpine arm/annapurna/alpine/hal arm/conf boot/fdt/dts/arm Message-ID: <A5EEDD9F-30C6-451B-9A1B-1CC9AE132019@gmail.com> In-Reply-To: <1431957864.91685.57.camel@freebsd.org> References: <201505151825.t4FIPnxJ099637@svn.freebsd.org> <CAJ-Vmomw3QeX4QfwN3ZH%2BcgJGbcJJT0LyjF8d%2B2EX0vExQzYog@mail.gmail.com> <059F2C65-F92D-445C-B603-0FAE0CAF976D@gmail.com> <1431877581.91685.49.camel@freebsd.org> <CAF6rxg=kNFBhDWY0VZKWUb=sVRc-XRtJVGOquEAX=jcdq_CkYA@mail.gmail.com> <7F73A915E7DF0EE8DC6149EC@atuin.in.mat.cc> <1431957864.91685.57.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On May 18, 2015, at 07:04, Ian Lepore <ian@freebsd.org> wrote: > >> On Mon, 2015-05-18 at 10:14 +0200, Mathieu Arnold wrote: >> +--On 18 mai 2015 00:21:43 -0700 Eitan Adler <eadler@freebsd.org> wrote: >> | On 17 May 2015 at 08:46, Ian Lepore <ian@freebsd.org> wrote: >> |> On Sat, 2015-05-16 at 21:04 -0700, Garrett Cooper wrote: >> |>> > On May 16, 2015, at 18:45, Adrian Chadd <adrian@freebsd.org> wrote: >> |>> > >> |>> > Did you commit files with DOS newlines in them? :) >> |>> > >> |>> > tsk tsk tsk tsk tsk. I think should fix that.. >> |>> >> |>> Better yet it should probably be disabled in svn... >> |>> >> |> >> |> Or flagged by some filter as a diff is uploaded to phabricator, since >> |> the web display obscures whitespace. >> | >> | This is possible. Would blocking all diffs that match /\r\n$/ work? >> >> That would crap up all patches that match that, which is a bad idea. > > Why would that be a bad idea? Do we have files in the system that > legitimately end with MSDOS line endings that need to be preserved as > such? > > I'm not sure blocking is the right thing anyway, it would be better if > it was like a warning dialog..."The diff you just uploaded contains DOS > line endings, continue?" There are some files in contrib/ with CRLF endings iirc... Thanks!
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A5EEDD9F-30C6-451B-9A1B-1CC9AE132019>