Date: Sun, 8 Jun 2003 16:56:33 +0930 From: Greg 'groggy' Lehey <grog@FreeBSD.org> To: Juli Mallett <jmallett@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/asf Makefile asf.c Message-ID: <20030608072633.GD9304@wantadilla.lemis.com> In-Reply-To: <20030608021354.A40746@FreeBSD.org> References: <200306080618.h586ID4a026484@repoman.freebsd.org> <20030608021354.A40746@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--xB0nW4MQa6jZONgY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sunday, 8 June 2003 at 2:13:54 -0500, Juli Mallett wrote: > * Greg Lehey <grog@FreeBSD.org> [ Date: 2003-06-08 ] > [ w.r.t. cvs commit: src/usr.sbin/asf Makefile asf.c ] >> grog 2003/06/07 23:18:13 PDT >> >> FreeBSD src repository >> >> Added files: >> usr.sbin/asf Makefile asf.c >> Log: >> Introducing asf, a helper program for kernel debugging. > > This looks pretty messy and doesn't even have a license on it. Yup. To be added. > Will it be tied to the build? That was my intention. Lots of other debugging tools are tied to the build. > Any reason it doesn't use the getopt(3) function, or in any way look > like the normal BSD style for utilities? It has a different origin. > Please use a paths.h instead of the evilly hardcoded program paths. paths.h is a bit of overkill for one file. But agreed, pathname definitions would be tidier. Feel free to fix. > If this won't be tied up to the build it should probably be in > src/tools, and I'd argue it should be there anyway. I thought about this. In fact, it started off that way, but the way this is intended to be used would make it inconvenient. Greg -- See complete headers for address and phone numbers --xB0nW4MQa6jZONgY Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.0 (FreeBSD) iD8DBQE+4uUpIubykFB6QiMRAnGWAJoDLYtqDMlbSIko2J7cyrcDAZKZIwCfW/zK diGme9wTYWkd+fPTq8+nst0= =sA4M -----END PGP SIGNATURE----- --xB0nW4MQa6jZONgY--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030608072633.GD9304>