Date: Mon, 03 Nov 2008 17:32:01 -0500 From: Joe Marcus Clarke <marcus@marcuscom.com> To: Ed Schouten <ed@80386.nl> Cc: gnome@freebsd.org, rink@freebsd.org Subject: Re: nspr and firefox3 on powerpc Message-ID: <1225751521.59532.14.camel@shumai.marcuscom.com> In-Reply-To: <20081103222020.GU1165@hoeg.nl> References: <20081103222020.GU1165@hoeg.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-ymPtLVblWSnjKB4dq3ZG
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
On Mon, 2008-11-03 at 23:20 +0100, Ed Schouten wrote:
> Hello all,
>=20
> I saw both the nspr and firefox3 ports were maintained by the GNOME
> folks, so I'd better send these patches to you, to ask if I can commit
> them to CVS.
>=20
> Last week I installed FreeBSD -CURRENT on my PowerBook G4 12". So far a
> lot of things start to work, but I noticed I wasn't able to compile my
> favourite browser on it. I've attached two patches, one for nspr and one
> for firefox3 to make them compile properly.
>=20
> nspr:
>=20
> The patch for nspr is quite obvious. _freebsd.cfg now returns an #error,
> because the platform is unsupported. Add the proper size definitions.
> I've copied these from _linux.cfg. Turns out the _openbsd.cfg and
> _netbsd.cfg definitions are quite probably a little broken, because they
> define PR_BYTES_PER_INT64 to 4. These bits should be correct, though.
>=20
> firefox3:
>=20
> This patch is a little more complex. The changes to the port Makefile:
> it turns out the `cc -dumpspecs | grep -m 1 pthread' trick doesn't work
> on powerpc, because the flag it tries to obtain is stored on the second
> line it returns. Make the pattern a little more accurate to make it work
> properly. GECKO_PTHREAD_LIBS is now -lpthread instead of a lot of random
> garbage.
>=20
> The fixes to the other file look a little strange, but that's mainly
> because diff(1) makes a mess out of it. The only thing it does, is make
> FreeBSD/powerpc use some of the Linux/powerpc xptcall bits that we need
> instead of bailing out because we're running an unknown architecture.
> We already do similar things for FreeBSD/{alpha,sparc64} and looking at
> the xptcall code it is a pretty sane decision to do this.
>=20
> Any comments?
We're fine with you committing PPC support for these ports. These
patches look okay to me. The pthread hack still works on i386 and
amd64. Thanks for doing this work!
Joe
--=20
PGP Key : http://www.marcuscom.com/pgp.asc
--=-ymPtLVblWSnjKB4dq3ZG
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)
iEYEABECAAYFAkkPe+AACgkQb2iPiv4Uz4dw7QCgjlxMxC16HdoxSqFoaZHd/113
yvIAnA25reigxCsSPX0shqfNjXZA9pxb
=uXp1
-----END PGP SIGNATURE-----
--=-ymPtLVblWSnjKB4dq3ZG--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1225751521.59532.14.camel>