Date: Mon, 14 Jan 2013 07:14:19 -0800 From: Garrett Cooper <yanegomi@gmail.com> To: Sean Bruno <sbruno@FreeBSD.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r245424 - head/sys/boot/i386/libi386 Message-ID: <45AA9DA0-E3F9-4AE7-A7E4-B9504B916038@gmail.com> In-Reply-To: <201301141505.r0EF5N18021253@svn.freebsd.org> References: <201301141505.r0EF5N18021253@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Thanks for taking care of these. I have a pr open to handle more issues, but= this took care of a chunk of them. Thanks, -Garrett Sent from my iPhone On Jan 14, 2013, at 7:05 AM, Sean Bruno <sbruno@FreeBSD.org> wrote: > Author: sbruno > Date: Mon Jan 14 15:05:22 2013 > New Revision: 245424 > URL: http://svnweb.freebsd.org/changeset/base/245424 >=20 > Log: > Quiesce some clang warnings while we're here doing stuff. >=20 > Submitted by: Hiren Panchasara <hiren.panchasara@gmail.com> > Obtained from: Yahoo! Inc >=20 > Modified: > head/sys/boot/i386/libi386/bootinfo64.c > head/sys/boot/i386/libi386/devicename.c > head/sys/boot/i386/libi386/pxe.c >=20 > Modified: head/sys/boot/i386/libi386/bootinfo64.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D > --- head/sys/boot/i386/libi386/bootinfo64.c Mon Jan 14 13:06:35 2013 = (r245423) > +++ head/sys/boot/i386/libi386/bootinfo64.c Mon Jan 14 15:05:22 2013 = (r245424) > @@ -134,7 +134,8 @@ bi_checkcpu(void) > { > char *cpu_vendor; > int vendor[3]; > - int eflags, regs[4]; > + int eflags; > + unsigned int regs[4]; >=20 > /* Check for presence of "cpuid". */ > eflags =3D read_eflags(); >=20 > Modified: head/sys/boot/i386/libi386/devicename.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D > --- head/sys/boot/i386/libi386/devicename.c Mon Jan 14 13:06:35 2013 = (r245423) > +++ head/sys/boot/i386/libi386/devicename.c Mon Jan 14 15:05:22 2013 = (r245424) > @@ -128,7 +128,7 @@ i386_parsedev(struct i386_devdesc **dev, > goto fail; > } > } else { > - cp =3D np; > + cp =3D (char *)np; > } > if (*cp && (*cp !=3D ':')) { > err =3D EINVAL; >=20 > Modified: head/sys/boot/i386/libi386/pxe.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D > --- head/sys/boot/i386/libi386/pxe.c Mon Jan 14 13:06:35 2013 (r2454= 23) > +++ head/sys/boot/i386/libi386/pxe.c Mon Jan 14 15:05:22 2013 (r2454= 24) > @@ -88,6 +88,12 @@ static int pxe_netif_get(struct iodesc * > static int pxe_netif_put(struct iodesc *desc, void *pkt, size_t len); > static void pxe_netif_end(struct netif *nif); >=20 > +#ifdef OLD_NFSV2 > +int nfs_getrootfh(struct iodesc*, char*, u_char*); > +#else > +int nfs_getrootfh(struct iodesc*, char*, uint32_t*, u_char*); > +#endif > + > extern struct netif_stats pxe_st[]; > extern u_int16_t __bangpxeseg; > extern u_int16_t __bangpxeoff; > _______________________________________________ > svn-src-head@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?45AA9DA0-E3F9-4AE7-A7E4-B9504B916038>