Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 21 Mar 2000 17:16:41 -0800
From:      "David O'Brien" <obrien@FreeBSD.ORG>
To:        Satoshi - Ports Wraith - Asami <asami@FreeBSD.ORG>
Cc:        ports@FreeBSD.ORG
Subject:   Re: "# Version required:"
Message-ID:  <20000321171641.A41941@dragon.nuxi.com>
In-Reply-To: <vqc3dqwlcmx.fsf@silvia.hip.berkeley.edu>; from asami@FreeBSD.ORG on Sun, Feb 13, 2000 at 06:51:50PM -0800
References:  <20000212180205.A42274@dragon.nuxi.com> <Pine.BSF.4.21.0002121805560.88574-100000@freefall.freebsd.org> <86puu1prj4.wl@daemon.local.idaemons.org> <vqc3dqwlcmx.fsf@silvia.hip.berkeley.edu>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Mar 20, 2000 at 10:20:45AM -0800, Satoshi - Ports Wraith - Asami wrote:
> Yes.  Sorry if I wasn't clear, but it was not a decision, just a hint
> on what might come in the future.  The handbook and portlint still
> clearly object to this.  I certainly didn't mean people can go change
> some subset of ports, that will make the ports tree inconsistent with
> itself.
> 
> When a change like this is proposed, this is how we proceed:
> 
> (1) we discuss the change, propose modifications, review patches, etc.

I propose the following patches, which remove the "# Version required: x.y"
comment as it is typically out of date, and tells nothing useful about
the port.  [In my 5 years doing ports, I've never gotten one ounce of
useful information from this comment line]

I see no need to make any decision on the outcome of any new port knobs
(such as PACAGE= and VERSION=) a requirement on us agreeing to apply
these two patches.


Index: chapter.sgml
===================================================================
RCS file: /home/ncvs/doc/en_US.ISO_8859-1/books/handbook/ports/chapter.sgml,v
retrieving revision 1.91
diff -u -r1.91 chapter.sgml
--- chapter.sgml	2000/03/17 16:46:01	1.91
+++ chapter.sgml	2000/03/22 00:53:50
@@ -1023,7 +1023,6 @@
 
         <programlisting>
 # New ports collection makefile for:   oneko
-# Version required:    1.1b
 # Date created:        5 December 1994
 # Whom:                asami
 #
@@ -4034,8 +4033,6 @@
       <programlisting>
 [the header...just to make it easier for us to identify the ports.]
 # New ports collection makefile for:   xdvi
-[the version required header should updated when upgrading a port.]
-# Version required:    pl18 [things like "1.5alpha" are fine here too]
 [this is the date when the first version of this Makefile was created.
 Never change this when doing an update of the port.]
 # Date created:                26 May 1995



Index: portlint.pl
===================================================================
RCS file: /home/ncvs/ports/devel/portlint/src/portlint.pl,v
retrieving revision 1.15
diff -u -r1.15 portlint.pl
--- portlint.pl	2000/03/20 18:03:01	1.15
+++ portlint.pl	2000/03/22 01:06:36
@@ -635,7 +635,6 @@
 	print "OK: checking comment section of $file.\n" if ($verbose);
 	@linestocheck = split("\n", <<EOF);
 Whom
-Version [rR]equired
 Date [cC]reated
 EOF
 	if ($osname eq 'NetBSD') {


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000321171641.A41941>