Date: Mon, 28 Dec 2015 20:50:55 +1100 From: Kubilay Kocak <koobs@FreeBSD.org> To: Olli Hauer <ohauer@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r404619 - in head/devel/bugzilla50: . files Message-ID: <568105FF.5000003@FreeBSD.org> In-Reply-To: <201512280947.tBS9l3TA036628@repo.freebsd.org> References: <201512280947.tBS9l3TA036628@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 28/12/2015 8:47 PM, Olli Hauer wrote: > Author: ohauer > Date: Mon Dec 28 09:47:03 2015 > New Revision: 404619 > URL: https://svnweb.freebsd.org/changeset/ports/404619 > > Log: > - Set submitter_id before calling _check_data() [1] > - bump PORTREVISION > > [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1235270 > > PR: 205657 > Submitted by: mokhi64(_at_)gmail.com > Reviewed by: koobs@ > > Added: > head/devel/bugzilla50/files/patch-Bugzilla_Attachment.pm (contents, props changed) > Modified: > head/devel/bugzilla50/Makefile > > Modified: head/devel/bugzilla50/Makefile > ============================================================================== > --- head/devel/bugzilla50/Makefile Mon Dec 28 09:46:40 2015 (r404618) > +++ head/devel/bugzilla50/Makefile Mon Dec 28 09:47:03 2015 (r404619) > @@ -2,6 +2,7 @@ > > PORTNAME= bugzilla > PORTVERSION= 5.0.2 > +PORTREVISION= 1 > CATEGORIES= devel > MASTER_SITES= MOZILLA/webtools MOZILLA/webtools/archived > > > Added: head/devel/bugzilla50/files/patch-Bugzilla_Attachment.pm > ============================================================================== > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/devel/bugzilla50/files/patch-Bugzilla_Attachment.pm Mon Dec 28 09:47:03 2015 (r404619) > @@ -0,0 +1,23 @@ > +# Bug 1235270 - Set submitter_id before calling _check_data() > +# https://bugzilla.mozilla.org/show_bug.cgi?id=1235270 > +# Status: Upstreamed, pending next release > + > +--- Bugzilla/Attachment.pm.orig 2015-12-22 21:22:10 UTC > ++++ Bugzilla/Attachment.pm > +@@ -865,6 +865,8 @@ sub create { > + sub run_create_validators { > + my ($class, $params) = @_; > + > ++ $params->{submitter_id} = Bugzilla->user->id || ThrowUserError('invalid_user'); > ++ > + # Let's validate the attachment content first as it may > + # alter some other attachment attributes. > + $params->{data} = $class->_check_data($params); > +@@ -872,7 +874,6 @@ sub run_create_validators { > + > + $params->{creation_ts} ||= Bugzilla->dbh->selectrow_array('SELECT LOCALTIMESTAMP(0)'); > + $params->{modification_time} = $params->{creation_ts}; > +- $params->{submitter_id} = Bugzilla->user->id || ThrowUserError('invalid_user'); > + > + return $params; > + } > Thank you for the awesome response time Olli!
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?568105FF.5000003>