Date: Wed, 6 Mar 2013 21:40:06 GMT From: Brooks Davis <brooks@FreeBSD.org> To: Perforce Change Reviews <perforce@FreeBSD.org> Subject: PERFORCE change 222673 for review Message-ID: <201303062140.r26Le6fj064551@skunkworks.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://p4web.freebsd.org/@@222673?ac=10 Change 222673 by brooks@brooks_zenith on 2013/03/06 21:39:17 Fix a truly embarrassing bug that resulted in only the first buffer of the block being written. Performance is still quite good, but not as good as when I was only writing 1/128 of the data. Be more consistant about which address we write commands to. This doesn't appear to have been a functional issue with ISF parts, but consistancy is a good thing. Affected files ... .. //depot/projects/ctsrd/beribsd/src/sys/dev/cfi/cfi_core.c#11 edit Differences ... ==== //depot/projects/ctsrd/beribsd/src/sys/dev/cfi/cfi_core.c#11 (text+ko) ==== @@ -545,13 +545,13 @@ break; } - cfi_write(sc, sc->sc_wrofs, CFI_BCS_CONFIRM); + cfi_write(sc, sc->sc_wrofs + i, + CFI_BCS_CONFIRM); - error = cfi_wait_ready(sc, sc->sc_wrofs + 1, + error = cfi_wait_ready(sc, sc->sc_wrofs + i, &start, CFI_TIMEOUT_BUFWRITE); - - goto out; } + goto out; default: /* Fall through to single word case */ break;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201303062140.r26Le6fj064551>