Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 31 Mar 2009 14:30:47 +0000 (UTC)
From:      John Baldwin <jhb@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r190593 - head/lib/libstand
Message-ID:  <200903311430.n2VEUlSG002556@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: jhb
Date: Tue Mar 31 14:30:46 2009
New Revision: 190593
URL: http://svn.freebsd.org/changeset/base/190593

Log:
  Fix an off-by-one buffer overflow in ngets().
  
  Submitted by:	Bruce Can
  MFC after:	1 month

Modified:
  head/lib/libstand/gets.c

Modified: head/lib/libstand/gets.c
==============================================================================
--- head/lib/libstand/gets.c	Tue Mar 31 12:51:49 2009	(r190592)
+++ head/lib/libstand/gets.c	Tue Mar 31 14:30:46 2009	(r190593)
@@ -74,7 +74,7 @@ ngets(char *buf, int n)
 	    putchar('\n');
 	    break;
 	default:
-	    if ((n < 1) || ((lp - buf) < n)) {
+	    if ((n < 1) || ((lp - buf) < n - 1)) {
 		*lp++ = c;
 		putchar(c);
 	    }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200903311430.n2VEUlSG002556>