Date: Sat, 18 Apr 2015 23:36:05 +0800 From: Marcelo Araujo <araujobsdport@gmail.com> To: current@freebsd.org, Takanori Watanabe <takawata@freebsd.org>, David Wolfskill <david@catwhisker.org> Subject: Re: Fix for r281680 -- broke i386 world Message-ID: <CAOfEmZjhxDCD3cWC34iHcOpHKedZpPvXma8U3oA-ncYdkOGYEw@mail.gmail.com> In-Reply-To: <20150418151702.GB36163@albert.catwhisker.org> References: <20150418151702.GB36163@albert.catwhisker.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi,
Saw your patch, why %ju and not %llx as the output shows?
Best,
Head/amd64 @ r281689 built OK, but my i386 build failed:
...
--- usr.sbin.all__D ---
--- all_subdir_bluetooth ---
/usr/src/usr.sbin/bluetooth/hccontrol/le.c:236:4: error: format specifies
type 'unsigned long' but the argument has type 'u_int64_t' (aka 'unsigned
long long') [-Werror,-Wformat]
rp.le_features);
^~~~~~~~~~~~~~
/usr/src/usr.sbin/bluetooth/hccontrol/le.c:253:49: error: format specifies
type 'unsigned long' but the argument has type 'u_int64_t' (aka 'unsigned
long long') [-Werror,-Wformat]
printf("LE_STATUS: %d %d %lx\n", e, rp.status, rp.le_status);
~~~ ^~~~~~~~~~~~
%llx
2 errors generated.
....
The attached patch allows i386 to build, and I then tested to verify
that amd64 still built. (I don't have Bluetooth devices, so I
cannot test its operation.)
Peace,
david
--
David H. Wolfskill david@catwhisker.org
Those who murder in the name of God or prophet are blasphemous cowards.
See http://www.catwhisker.org/~david/publickey.gpg for my public key.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOfEmZjhxDCD3cWC34iHcOpHKedZpPvXma8U3oA-ncYdkOGYEw>