Date: Sun, 27 Jul 2008 10:58:51 +1000 (EST) From: Edwin Groothuis <edwin@mavetju.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/125996: [patch] x11/nvidia-drive - remove pkg_info statements Message-ID: <20080727005851.C8A07A2B@k7.mavetju> Resent-Message-ID: <200807270100.m6R10DmB031395@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 125996
>Category: ports
>Synopsis: [patch] x11/nvidia-drive - remove pkg_info statements
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Sun Jul 27 01:00:13 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator: Edwin Groothuis
>Release: FreeBSD 7.0-RELEASE-p1 i386
>Organization:
-
>Environment:
System: FreeBSD k7.mavetju 7.0-RELEASE-p1 FreeBSD 7.0-RELEASE-p1 #2: Wed May 28 08:12:56 EST 2008 edwin@k7.mavetju:/usr/src/sys/i386/compile/k7 i386
>Description:
>How-To-Repeat:
>Fix:
Cleanup of x11/nvidia-driver
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/x11/nvidia-driver/Makefile,v
retrieving revision 1.79
diff -u -r1.79 Makefile
--- Makefile 18 Jun 2008 19:46:18 -0000 1.79
+++ Makefile 27 Jul 2008 00:45:08 -0000
@@ -40,10 +40,8 @@
.include <bsd.port.pre.mk>
-# XXX Should use ${PKG_INFO} XXX
-#
-XSERVVERSION!= /usr/sbin/pkg_info -O x11-servers/XFree86-4-Server 2>/dev/null | ${GREP} Server- || /usr/sbin/pkg_info -O x11-servers/xorg-server 2>/dev/null | ${GREP} server- || /usr/sbin/pkg_info -qO x11-servers/xorg-server-snap 2>/dev/null || true
-XLIBVERSION!= /usr/sbin/pkg_info -O x11/XFree86-4-libraries 2>/dev/null | ${GREP} libraries- || /usr/sbin/pkg_info -O graphics/libGL 2>/dev/null | ${GREP} libGL- || true
+XSERVVERSION!= ${PKG_INFO} -O x11-servers/XFree86-4-Server 2>/dev/null | ${GREP} Server- || ${PKG_INFO} -O x11-servers/xorg-server 2>/dev/null | ${GREP} server- || ${PKG_INFO} -qO x11-servers/xorg-server-snap 2>/dev/null || true
+XLIBVERSION!= ${PKG_INFO} -O x11/XFree86-4-libraries 2>/dev/null | ${GREP} libraries- || ${PKG_INFO} -O graphics/libGL 2>/dev/null | ${GREP} libGL- || true
.if empty(XSERVVERSION)
IGNORE= needs an X server implementation installed
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080727005851.C8A07A2B>