Date: Wed, 11 Mar 2009 15:57:30 +0200 From: Andriy Gapon <avg@icyb.net.ua> To: Eitan Adler <eitanadlerlist@gmail.com> Cc: freebsd-ports@FreeBSD.ORG Subject: Re: request for a new port review [memtest86+] Message-ID: <49B7C34A.7090900@icyb.net.ua> In-Reply-To: <49B7C206.1040508@gmail.com> References: <49B6A827.50705@icyb.net.ua> <49B7BE84.3050106@gmail.com> <49B7BFC8.3010202@icyb.net.ua> <49B7C206.1040508@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
on 11/03/2009 15:52 Eitan Adler said the following: > Andriy Gapon wrote: >> on 11/03/2009 15:37 Eitan Adler said the following: >>> Andriy Gapon wrote: >>>> Guys, >>>> >>>> could you please review the below port for correctness, style and general approach >>>> taken by me. >>> http://isis.poly.edu/~eitan/files/patch-memtest86+-port.diff >>> Apply this patch then install the port "portlint" and run portlint -CNA. >>> >>> Always use tabs - not spaces. >> Something must have been screwed during transfer, I do have tabs not spaces here - >> otherwise makefile syntax would be incorrect, nothing would work and I wouldn't >> even attempt to submit such a mess. >> > > These are the commands I used to fetch and extract: > $fetch http://www.icyb.net.ua/~avg/memtest86+.port.shar.txt My mistake, explained in another email, already fixed. > $sh memtest86+.port.shar.txt > $cd memtest86+ > $portlint -CNA > > Either way run portlint -CNA. Done. > When this passes submit a PR with the > port. I'd like to wait some time to get some feedback on the substance of the port. > Also since you don't have spaces my diff won't apply but I think > you should change BOOT_DIR= /boot/opt to BOOT_DIR?= /boot/opt so the > location can be specified by the user. Very good idea, I'll do it. Thank you! -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?49B7C34A.7090900>