Date: Fri, 23 Aug 2013 11:05:13 -0700 From: John-Mark Gurney <jmg@funkthat.com> To: Mike Tancsa <mike@sentex.net> Cc: Ollivier Robert <roberto@keltia.freenix.fr>, freebsd-current@freebsd.org, security@freebsd.org Subject: Re: patch to improve AES-NI performance Message-ID: <20130823180513.GM94127@funkthat.com> In-Reply-To: <52177F0B.9020906@sentex.net> References: <20130822202027.GH94127@funkthat.com> <20130823151615.GD41379@roberto02-aw.erc.corp.eurocontrol.int> <52177F0B.9020906@sentex.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Mike Tancsa wrote this message on Fri, Aug 23, 2013 at 11:26 -0400:
> On 8/23/2013 11:16 AM, Ollivier Robert wrote:
> > According to John-Mark Gurney on Thu, Aug 22, 2013 at 01:20:27PM -0700:
> >> I have developed a patch to improve AES-NI performance. If you took the
> >> AES-XTS algorithm into userland (no cryptodev or geli usage), these
> >> changes improve the performance over 10x in my tests (from ~150MB/sec to
> >> over 2GB/sec). In tests of geli on gnop, the performance improvement is
> >> more moderate, around 4x due to overhead in other parts of the system.
> >
> > Thanks a lot for this patch. Now, looking at it in the stable/9 context, I can see that pjd did not merge (as he said at the time of commit) r226839 & r226839. Is there any objection to merge these two (and possibly 247061 as well -- copyright update)?
> >
> > I ask that for two reasons, these two revisions are speeding up AES-NI quite a bit and they are required for using jmg's patch.
> >
> > I'll be testing all this in the next few days on my new AES-NI enabled machine.
> >
>
> Speeding up userland AES is very interesting to me for a couple of apps.
> If there is a proper way I should test on RELENG_9, please let me know
> as I am few boxes that I would be happy to test/deploy on.
My patch would only effect userland applications that use /dev/crypto...
If they do their own AES-NI work, then there isn't any improvement...
--
John-Mark Gurney Voice: +1 415 225 5579
"All that I will do, has been done, All that I have, has not."
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130823180513.GM94127>