Date: Sat, 26 May 2001 01:02:39 -0400 From: Alfred Perlstein <alfred@FreeBSD.ORG> To: Dima Dorfman <dima@unixfreak.org> Cc: current@FreeBSD.ORG Subject: Re: vm_pager_(de)allocate and vm_mtx Message-ID: <20010526010239.G17514@superconductor.rush.net> In-Reply-To: <20010526022209.CA0203E2F@bazooka.unixfreak.org>; from dima@unixfreak.org on Fri, May 25, 2001 at 07:22:09PM -0700 References: <20010526022209.CA0203E2F@bazooka.unixfreak.org>
next in thread | previous in thread | raw e-mail | index | archive | help
* Dima Dorfman <dima@unixfreak.org> [010525 22:22] wrote: > Is there a reason vm_pager_allocate acquires vm_mtx itself if > necessary but vm_pager_deallocate does not? At the moment, detaching > an md(4) disk will panic the system with a failed mtx_assert in > vm_pager_deallocate. This can be fixed one of two ways: > vm_pager_deallocate could be made to deal with vm_mtx itself like > vm_pager_allocate does, or md(4) and any other drivers which call > vm_pager_deallocate can be fixed to acquire vm_mtx. So which will it > be? I'll supply patches for either case. Usually fixing the caller is better as it will catch people that expect vm state to remain unchanged across several calls. -- -Alfred Perlstein [alfred@freebsd.org] Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010526010239.G17514>