Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 28 Jul 2008 05:22:12 +0900 (JST)
From:      Ayumi M <ayu@commun.jp>
To:        FreeBSD-gnats-submit@FreeBSD.org
Cc:        r.vdooren@snow.nl
Subject:   ports/126014: [PATCH] sysutils/rsnapshot: 'ssh_arg' option broken
Message-ID:  <20080727202212.2ADA05FAC@dahlia.commun.jp>
Resent-Message-ID: <200807272030.m6RKU4fU068909@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         126014
>Category:       ports
>Synopsis:       [PATCH] sysutils/rsnapshot: 'ssh_arg' option broken
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jul 27 20:30:03 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Ayumi M
>Release:        FreeBSD 7.0-RELEASE-p2 i386
>Organization:
>Environment:
System: FreeBSD dahlia.commun.jp 7.0-RELEASE-p2 FreeBSD 7.0-RELEASE-p2 #0: Wed Jun 18 07:33:20 UTC 2008
>Description:
ssh_args does not quote arguments

Added file(s):
- files/patch-rsnapshot-program.pl

Port maintainer (r.vdooren@snow.nl) is cc'd.

Generated with FreeBSD Port Tools 0.77
>How-To-Repeat:
add following line to rsnapshot.conf

ssh_args	-p 22
>Fix:

--- rsnapshot-1.3.0_2.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/sysutils/rsnapshot-1.3.0_1/Makefile /usr/ports/sysutils/rsnapshot/Makefile
--- /usr/ports/sysutils/rsnapshot-1.3.0_1/Makefile	2008-07-28 04:55:19.000000000 +0900
+++ /usr/ports/sysutils/rsnapshot/Makefile	2008-07-28 05:02:00.000000000 +0900
@@ -7,7 +7,7 @@
 
 PORTNAME=	rsnapshot
 PORTVERSION=	1.3.0
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	sysutils
 MASTER_SITES=	http://www.rsnapshot.org/downloads/
 
diff -ruN --exclude=CVS /usr/ports/sysutils/rsnapshot-1.3.0_1/files/patch-rsnapshot-program.pl /usr/ports/sysutils/rsnapshot/files/patch-rsnapshot-program.pl
--- /usr/ports/sysutils/rsnapshot-1.3.0_1/files/patch-rsnapshot-program.pl	1970-01-01 09:00:00.000000000 +0900
+++ /usr/ports/sysutils/rsnapshot/files/patch-rsnapshot-program.pl	2008-07-28 05:00:31.000000000 +0900
@@ -0,0 +1,11 @@
+--- rsnapshot-program.pl.orig	2008-07-28 04:56:49.000000000 +0900
++++ rsnapshot-program.pl	2008-07-28 04:59:09.000000000 +0900
+@@ -3234,7 +3234,7 @@
+ 		
+ 		# if we have any args for SSH, add them
+ 		if ( defined($ssh_args) ) {
+-			push( @rsync_long_args_stack, "--rsh=$config_vars{'cmd_ssh'} $ssh_args" );
++			push( @rsync_long_args_stack, "--rsh=\"$config_vars{'cmd_ssh'} $ssh_args\"" );
+ 			
+ 		# no arguments is the default
+ 		} else {
--- rsnapshot-1.3.0_2.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080727202212.2ADA05FAC>