Date: Thu, 12 Jan 2006 13:26:12 +0100 From: Harald Schmalzbauer <harry@schmalzbauer.de> To: cvs-src@freebsd.org Cc: src-committers@freebsd.org, Pawel Jakub Dawidek <pjd@freebsd.org> Subject: Re: cvs commit: src/sys/kern kern_malloc.c Message-ID: <200601121326.19634@harrymail> In-Reply-To: <200512280153.jBS1rEd6086940@repoman.freebsd.org> References: <200512280153.jBS1rEd6086940@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart3129393.k1mnOZbaXg Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Am Mittwoch, 28. Dezember 2005 02:53 CEST schrieb Pawel Jakub Dawidek: > pjd 2005-12-28 01:53:13 UTC > > FreeBSD src repository > > Modified files: > sys/kern kern_malloc.c > Log: > In realloc(9), determine size of the original block based on > UMA_SLAB_MALLOC flag. > In some circumstances (I observed it when I was doing a lot of > reallocs) UMA_SLAB_MALLOC can be set even if us_keg !=3D NULL. > > If this is the case we have wonderful, silent data corruption, because > less data is copied to the newly allocated region than should be. > > I'm not sure when this bug was introduced, it could be there > undetected for years now, as we don't have a lot of realloc(9) consumers > and it was hard to reproduce it... > ...but what I know for sure, is that I don't want to know who > introduce the bug:) It took me two/three days to track it down (of > course most of the time I was looking for the bug in my own code). > > Revision Changes Path > 1.150 +1 -1 src/sys/kern/kern_malloc.c Thanks for your work, I'm using it in RELENG_6 from day one without any=20 impact, so perhaps it's safe to MFC? =2DHarry > _______________________________________________ > cvs-src@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/cvs-src > To unsubscribe, send any mail to "cvs-src-unsubscribe@freebsd.org" --nextPart3129393.k1mnOZbaXg Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQBDxkrrBylq0S4AzzwRApzTAJ91KMYcPoTkUmbGMgPaehfzSgtmXgCfcshR dS52fxQOuhAuJOCdyxPf4Fc= =8y16 -----END PGP SIGNATURE----- --nextPart3129393.k1mnOZbaXg--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200601121326.19634>