Date: Fri, 2 Jul 1999 21:47:48 -0400 (EDT) From: "Brian F. Feldman" <green@unixhelp.org> To: Greg Lehey <grog@lemis.com> Cc: current@FreeBSD.ORG Subject: Re: Fixing other people's code (was: world broken in vinum (PATCH)) Message-ID: <Pine.BSF.4.10.9907022146010.12249-100000@janus.syracuse.net> In-Reply-To: <19990703093223.V87392@freebie.lemis.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 3 Jul 1999, Greg Lehey wrote:
> On Friday, 2 July 1999 at 15:26:35 -0400, Brian F. Feldman wrote:
> > On Fri, 2 Jul 1999, Brian F. Feldman wrote:
> >
> >> Here's the fix. I'm sure it's not absolutely the same as what Greg will have,
> >> but if anyone wants to commit it, it will fix world.
> >
> > I know I _could_ commit it, but it's someone else's work that's being actively
> > maintained. It still does break world, but I don't think I have authority to
> > commit over Greg's work.
>
> I personally think that, in such a case, you'd be justified to commit
> it as a temporary measure. Due to the difference in time zones, this
> has hit people while I've been asleep. That doesn't mean the commit
> would stay, of course, but at least it would save people unnecessary
> pain. Note, of course, that I have now committed the correct file,
> which I had forgotten last night.
This is exactly how I felt. I knew that what I was doing was correct, even
if it wasn't the same as what you had, and you would fix it up when you
had the chance. However, I had no case to set a precedent of what to do;
last time vinum was broken for a long time because phk's changes didn't get
reviewed for a while; he didn't want things to go wrong, so he didn't commit
it. This was simpler, but I didn't want to do things that are wrong.
>
> What do you others think?
>
> Greg
> --
> See complete headers for address, home page and phone numbers
> finger grog@lemis.com for PGP public key
>
>
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-current" in the body of the message
>
Brian Fundakowski Feldman _ __ ___ ____ ___ ___ ___
green@FreeBSD.org _ __ ___ | _ ) __| \
FreeBSD: The Power to Serve! _ __ | _ \._ \ |) |
http://www.FreeBSD.org/ _ |___/___/___/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.10.9907022146010.12249-100000>