Date: Mon, 14 Oct 2013 23:24:39 -0400 From: Julio Merino <julio@meroh.net> To: freebsd-testing@freebsd.org Cc: Rui Paulo <rpaulo@fnop.net>, Garrett Cooper <yanegomi@gmail.com>, Simon Gerraty <sjg@juniper.net> Subject: Re: Refactoring of *.test.mk Message-ID: <CADyfeQW5z6aWH1sfnGF5mbWGeHap-o4j7Y4ttqGRU5WDqMbABg@mail.gmail.com> In-Reply-To: <CADyfeQVTx3LUo3Q-bcPPmG3Xx4TPtRcJB1%2Bzk6ms_-zz%2Box6eg@mail.gmail.com> References: <CADyfeQVTx3LUo3Q-bcPPmG3Xx4TPtRcJB1%2Bzk6ms_-zz%2Box6eg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[Fixing Garrett's address...] On Mon, Oct 14, 2013 at 10:44 PM, Julio Merino <julio@meroh.net> wrote: > Hello all, > > [ CCing a few people directly that are probably interested. ] > > After the recent removal of the deprecated ATF tools from the tree, I > have been working on a refactoring of the FreeBSD *.test.mk Makefiles > to add various features that spilled from that change. > > The highlights of this work so far: > > - Clearly documented the interface of each *.test.mk file by putting > the list of public variables at the top and adding comments where due. > > - Split the logic to build framework-less test programs into a new > plain.test.mk file. This is in accordance with atf.test.mk, but also > helps clarifying the code, defining a proper interfac in bsd.test.mk > and makes some of the other changes simpler. > > - Added support to generate both Atffile and Kyuafile files. > > - Added support to run the tests using both atf-run and kyua (from ports). > > You can find the relevant patches in: > http://portal.meroh.net/~jmmv/freebsd-testing/ . > > The patches have been generated using quilt so take a look at the > contents of the 'series' file to see in which order they would need to > be applied. > > Each patch has a description at the top which can later be used as the > commit log. > > Note that, at the moment, this can only be exercised in > lib/libcrypt/tests/ . I actually wanted to write some tests for > *.test.mk themselves (!) but I wouldn't want to spend time on that > before agreeing that this structure is sensible. If it is, I might put > the effort ;-) See the ones here > http://cvsweb.netbsd.org/bsdweb.cgi/src/tests/share/mk/?only_with_tag=MAIN > to get an idea of what they could look like. > > Anybody up for reviewing these patches and sharing their comments? > > Thanks! > > -- > Julio Merino / @jmmv -- Julio Merino / @jmmv
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADyfeQW5z6aWH1sfnGF5mbWGeHap-o4j7Y4ttqGRU5WDqMbABg>