Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 14 Mar 2006 20:25:56 +0300
From:      Andrey Chernov <ache@FreeBSD.ORG>
To:        Andre Oppermann <andre@FreeBSD.ORG>
Cc:        cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject:   Re: cvs commit: src/lib/libc/stdlib Makefile.inc Symbol.map strtonum.3 strtonum.c src/include stdlib.h
Message-ID:  <20060314172556.GA63170@nagual.pp.ru>
In-Reply-To: <200603141657.k2EGvU0p071401@repoman.freebsd.org>
References:  <200603141657.k2EGvU0p071401@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Mar 14, 2006 at 04:57:30PM +0000, Andre Oppermann wrote:
> andre       2006-03-14 16:57:30 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     lib/libc/stdlib      Makefile.inc Symbol.map 
>     include              stdlib.h 
>   Added files:
>     lib/libc/stdlib      strtonum.3 strtonum.c 
>   Log:
>   Import of OpenBSD's strtonum(3) which is a nicer version of strtoll(3)
>   providing proper error checking and other improvements.

Error checking isn't so proper as said.

if (numstr == ep || *ep != '\0')

must be

if (numstr == ep || *ep != '\0' || errno == EINVAL)

I'll commit this, if no objections.

-- 
http://ache.pp.ru/



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060314172556.GA63170>