Date: Thu, 30 Jan 2014 20:37:02 +0100 From: Juergen Lock <nox@jelal.kn-bremen.de> To: Mathieu Arnold <mat@FreeBSD.org> Cc: svn-ports-head@FreeBSD.org, Juergen Lock <nox@FreeBSD.org>, svn-ports-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: svn commit: r341790 - head/multimedia/szap-s2 Message-ID: <20140130193702.GA69785@enceladus10.kn-bremen.de> In-Reply-To: <33CFB80361C43DC17B99E87C@atuin.in.mat.cc> References: <201401292244.s0TMib46086321@svn.freebsd.org> <33CFB80361C43DC17B99E87C@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jan 29, 2014 at 11:48:43PM +0100, Mathieu Arnold wrote:
> +--On 29 janvier 2014 22:44:37 +0000 Juergen Lock <nox@FreeBSD.org> wrote:
> | +
> | +.include <bsd.port.options.mk>
> |
> | do-install:
> | (cd ${WRKSRC} && ${INSTALL_PROGRAM} szap-s2 ${STAGEDIR}/${PREFIX}/bin)
> | -.if !defined(NOPORTDOCS)
> | - ${MKDIR} ${DOCSDIR}
> | - (cd ${WRKSRC} && ${INSTALL_DATA} ${PORTDOCS} ${DOCSDIR})
> | +.if ${PORT_OPTIONS:MDOCS}
> | + ${MKDIR} ${STAGEDIR}${DOCSDIR}
> | + (cd ${WRKSRC} && ${INSTALL_DATA} ${PORTDOCS} ${STAGEDIR}${DOCSDIR})
> | .endif
>
> Hi,
>
> Could you remove the include of port.options and always install the DOCS
> into the staging area ? It would save us parsing bsd.port.mk one time too
> many.
>
> Like it says on https://wiki.freebsd.org/ports/StageDir
>
> The DOCS/EXAMPLES .if blocks can be made unconditional, except in cases
> when installed files are big enough to cause significant I/O overhead.
>
Indeed, I should have remembered this... Fixed.
Thanx! :)
Juergen
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140130193702.GA69785>