Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 7 Aug 2010 17:39:22 +0000 (UTC)
From:      Attilio Rao <attilio@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-projects@freebsd.org
Subject:   svn commit: r211029 - projects/sv/sys/net
Message-ID:  <201008071739.o77HdM2Y009458@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: attilio
Date: Sat Aug  7 17:39:22 2010
New Revision: 211029
URL: http://svn.freebsd.org/changeset/base/211029

Log:
  Add a tunable for nd_enable.
  As long as TUNABLE_INT is discouraged, however, switch the type int -> long
  and adjust accordingly the sysctl stubs.

Modified:
  projects/sv/sys/net/netdump_client.c

Modified: projects/sv/sys/net/netdump_client.c
==============================================================================
--- projects/sv/sys/net/netdump_client.c	Sat Aug  7 17:30:15 2010	(r211028)
+++ projects/sv/sys/net/netdump_client.c	Sat Aug  7 17:39:22 2010	(r211029)
@@ -162,7 +162,7 @@ static unsigned char buf[MAXDUMPPGS*PAGE
 						 * us */
 static struct ether_addr nd_server_mac;
 
-static int nd_enable = 0;  /* if we should perform a network dump */
+static long nd_enable = 0;  /* if we should perform a network dump */
 static struct in_addr nd_server = {INADDR_ANY}; /* server address */
 static struct in_addr nd_client = {INADDR_ANY}; /* client (our) address */
 struct ifnet *nd_nic = NULL;
@@ -331,8 +331,6 @@ sysctl_force_crash(SYSCTL_HANDLER_ARGS) 
 }
 
 SYSCTL_NODE(_net, OID_AUTO, dump, CTLFLAG_RW, 0, "netdump");
-SYSCTL_INT(_net_dump, OID_AUTO, enable, CTLTYPE_INT|CTLFLAG_RW, &nd_enable, 0,
-	"enable network dump");
 SYSCTL_PROC(_net_dump, OID_AUTO, server, CTLTYPE_STRING|CTLFLAG_RW, &nd_server,
 	0, sysctl_ip, "A", "dump server");
 SYSCTL_PROC(_net_dump, OID_AUTO, client, CTLTYPE_STRING|CTLFLAG_RW, &nd_client,
@@ -345,6 +343,9 @@ SYSCTL_INT(_net_dump, OID_AUTO, polls, C
 	"times to poll NIC per retry");
 SYSCTL_INT(_net_dump, OID_AUTO, retries, CTLTYPE_INT|CTLFLAG_RW, &nd_retries, 0,
 	"times to retransmit lost packets");
+SYSCTL_LONG(_net_dump, OID_AUTO, enable, CTLTYPE_LONG|CTLFLAG_RW, &nd_enable,
+	0, "enable network dump");
+TUNABLE_LONG("net.dump.enable", &nd_enable);
 
 /*-
  * Network specific primitives.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201008071739.o77HdM2Y009458>