Date: Thu, 1 Nov 2001 13:35:35 -0800 (PST) From: Julian Elischer <julian@elischer.org> To: Robert Watson <rwatson@FreeBSD.org> Cc: arch@FreeBSD.org Subject: Re: Changes to suser() and friends Message-ID: <Pine.BSF.4.21.0111011332350.42259-100000@InterJet.elischer.org> In-Reply-To: <Pine.NEB.3.96L.1011101160457.6122D-100000@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 1 Nov 2001, Robert Watson wrote: > > error = suser(p->p_ucred); > or > error = suser(td->td_proc->p_ucred); > or > error = suser(td->td_ucred); the reason for the existance of suser_td is so that it could be called by functions for which 'thread *' was an opaque pointer.. i.e. there are many places that use suser() and suser_td() that do not include proc.h and thus do not know about any sub elements of the thread structure. (or proc structure) by making this change you are forcing these file sto include proc.h. this is not hard, but just another move towards "every file includes every .h file" > > is substantial. In fact, given that threads will have access to two > credentials (the thread cached credential, and the process credential), > making it explicit is probably a very good idea. > > Assuming there are no objections, I plan to commit this change on Monday. > > Robert N M Watson FreeBSD Core Team, TrustedBSD Project > robert@fledge.watson.org NAI Labs, Safeport Network Services > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-arch" in the body of the message > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0111011332350.42259-100000>