Date: Tue, 12 Jun 2007 06:01:19 -0400 From: Andrew Gallatin <gallatin@cs.duke.edu> To: Andre Oppermann <andre@FreeBSD.org> Cc: Sam Leffler <sam@errno.com>, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/net if.h Message-ID: <20070612060118.B84335@grasshopper.cs.duke.edu> In-Reply-To: <466DB2FF.9060300@freebsd.org>; from andre@FreeBSD.org on Mon, Jun 11, 2007 at 10:39:04PM %2B0200 References: <200706112008.l5BK8CQ7033543@repoman.freebsd.org> <466DACD6.4040606@errno.com> <466DB2FF.9060300@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Andre Oppermann [andre@FreeBSD.org] wrote: > Sam Leffler wrote: > > Andre Oppermann wrote: > >> andre 2007-06-11 20:08:12 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/net if.h Log: > >> Add IFCAP_LRO flag for drivers to announce their TCP Large Receive > >> Offload > >> capabilities. > >> Revision Changes Path > >> 1.108 +1 -0 src/sys/net/if.h > >> http://cvsweb.FreeBSD.org/src/sys/net/if.h.diff?r1=1.107&r2=1.108 > >> > >> > > There are many offload capabilities defined that are not well thought > > out. In particular we do not distinguish between ipv4 and ipv6 for > > things like cksum and tso so there's no way to disable individual > > features. The ability to tweak LRO is clearly needed and clearly belong > > as an ifnet capability but unilateraly deciding this is the wrong approach. > > We do distinguish between TSO4 and TSO6 since from the beginning. > > LRO is not hardware dependent but done in software. However it must > be handled from inside the drivers RX function. Our software > implementation will be IPv4 and IPv6 aware right from the beginning. > > It is not an unilateral decision if other directly affected developers > agree (Drew, Jack). I'm fine with it, as long as it is "OK" for the current in-driver software implementations to not support v6. I believe mxge and cxgb both only supprt v4. Drew
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070612060118.B84335>