Date: Wed, 26 Mar 2003 00:51:20 +0100 From: Maxime Henrion <mux@freebsd.org> To: Mike Silbersack <silby@silby.com> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf options src/sys/netinet ip_output.c Message-ID: <20030325235120.GH57674@elvis.mu.org> In-Reply-To: <20030325162048.H1250@odysseus.silby.com> References: <200303250545.h2P5j5PM008552@repoman.freebsd.org> <20030324234234.T6129@odysseus.silby.com> <20030325222016.GF57674@elvis.mu.org> <20030325162048.H1250@odysseus.silby.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Mike Silbersack wrote: > > On Tue, 25 Mar 2003, Maxime Henrion wrote: > > > Looks like there is a bug in this code. I tried to understand what's > > wrong in the if_xl code that tries to deal with mbuf chains containing > > more than XL_MAXFRAGS mbufs, and noticed that m_head->m_pkthdr.len isn't > > set properly. The length of an mbuf chain shouldn't change when we're > > just splitting it into more mbufs, so this is kinda weird. Using > > m_fixhdr() just after the splitting code solves it, but that's probably > > just a workaround, and either m_split() or the MBUF_FRAG_TEST code needs > > to be fixed. > > Hm, the bug's probably in the frag test code. I'll take a look at it > later tonight, but you're welcome to fix it in the meantime. I committed a few fixes of mine. I hope the commit log explains the changes clearly enough. Cheers, Maxime
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030325235120.GH57674>