Date: Sat, 16 Aug 2008 17:39:12 -0700 From: Tim Kientzle <kientzle@freebsd.org> To: Anselm Strauss <strauss@freebsd.org> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 147527 for review Message-ID: <48A77330.3080501@freebsd.org> In-Reply-To: <200808161208.m7GC8kiI099130@repoman.freebsd.org> References: <200808161208.m7GC8kiI099130@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> + /* TODO: reader does not yet respect data descriptors. */ > + /*assertEqualInt((S_IFREG | 0755), archive_entry_mode(ae)); When writing uncompressed files, you *must* fill in the compressed and uncompressed sizes in the local file header (you can put them in the data descriptor also, but they must go into the local file header). Otherwise, the reader cannot tell where the data ends. (Unless it reads the central directory first, which it can't always do. For example, when reading archives from stdin, the reader cannot read the central directory first.) The CRC32, of course, cannot go in the local file header, so must go into the data descriptor. Tim
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?48A77330.3080501>