Date: Sun, 8 May 2005 16:18:37 -0700 From: bruno schwander <bruno@tinkerbox.org> To: Thierry Thomas <thierry@FreeBSD.org> Cc: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/80743: port update/fix: french/alphabet_sounds_fr Message-ID: <Pine.CYG.4.58.0505081610430.2828@hooked-lap1> In-Reply-To: <200505081522.j48FMebO018706@freefall.freebsd.org> References: <200505081522.j48FMebO018706@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Thierry,
You are right for the BUILD_DEPEND, thanks for catching that. However the
install dir should stay in $PREFIX/share/childsplay.
That is where similar data is installed by ports/games/childsplay and
ports/games/childsplay_plugins. It won't work if installed somewhere else.
It's a bunch of resources that are shared among childsplay and its
plugins, so it makes sense to put it there I think.
bruno
On Sun, 8 May 2005, Thierry Thomas wrote:
> Synopsis: port update/fix: french/alphabet_sounds_fr
>
> State-Changed-From-To: open->feedback
> State-Changed-By: thierry
> State-Changed-When: Sun May 8 15:19:01 GMT 2005
> State-Changed-Why:
>
> I suggest the following patch, to fix the dependency and
> the installation directory; could you please revie it?
>
> --- alphabet_sounds_fr.diff begins here ---
> diff -urN french/alphabet_sounds_fr.orig/Makefile french/alphabet_sounds_fr/Makefile
> --- french/alphabet_sounds_fr.orig/Makefile Sun May 8 17:15:40 2005
> +++ french/alphabet_sounds_fr/Makefile Sun May 8 17:06:47 2005
> @@ -5,7 +5,6 @@
>
> PORTNAME= alphabet_sounds_fr
> PORTVERSION= 0.3
> -PORTREVISION= 1
> CATEGORIES= french games
> MASTER_SITES= ${MASTER_SITE_SOURCEFORGE}
> MASTER_SITE_SUBDIR= childsplay
> @@ -14,7 +13,7 @@
> MAINTAINER= bruno@tinkerbox.org
> COMMENT= Educative games for children. Alphabet sounds package (french)
>
> -BUILD_DEPENDS= ${LOCALBASE}/bin/childsplay:${PORTSDIR}/games/childsplay
> +BUILD_DEPENDS= ${X11BASE}/bin/childsplay:${PORTSDIR}/games/childsplay
> RUN_DEPENDS= ${BUILD_DEPENDS}
>
> USE_REINPLACE= yes
> diff -urN french/alphabet_sounds_fr.orig/files/patch-install.sh french/alphabet_sounds_fr/files/patch-install.sh
> --- french/alphabet_sounds_fr.orig/files/patch-install.sh Sun May 8 17:15:40 2005
> +++ french/alphabet_sounds_fr/files/patch-install.sh Sun May 8 17:06:39 2005
> @@ -1,5 +1,5 @@
> --- install.sh.orig Mon Jun 28 13:44:23 2004
> -+++ install.sh Sun Aug 22 17:16:36 2004
> ++++ install.sh Sun May 8 17:06:06 2005
> @@ -1,8 +1,8 @@
> -#!/bin/bash
> -# install plugin in the standard childsplay path
> @@ -8,7 +8,7 @@
>
> PREFIX=/usr/local
> -DESTDIR=$PREFIX/games/childsplay
> -+DESTDIR=$PREFIX/share/childsplay
> ++DESTDIR=$PREFIX/childsplay
>
> ###########################################################
> # DO NOT EDIT BEHIND THIS POINT
> --- alphabet_sounds_fr.diff ends here ---
>
>
>
> Responsible-Changed-From-To: freebsd-ports-bugs->thierry
> Responsible-Changed-By: thierry
> Responsible-Changed-When: Sun May 8 15:19:01 GMT 2005
> Responsible-Changed-Why:
>
> Take it.
>
>
> http://www.freebsd.org/cgi/query-pr.cgi?pr=80743
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.CYG.4.58.0505081610430.2828>