Date: Tue, 12 Jun 2007 20:00:52 +0900 From: Pyun YongHyeon <pyunyh@gmail.com> To: Andrew Gallatin <gallatin@cs.duke.edu> Cc: src-committers@FreeBSD.org, kmacy@FreeBSD.org, cvs-src@FreeBSD.org, davidch@FreeBSD.org, cvs-all@FreeBSD.org, jfv@FreeBSD.org, Pyun YongHyeon <yongari@FreeBSD.org> Subject: Re: cvs commit: src/sys/dev/nfe if_nfe.c if_nfereg.h Message-ID: <20070612110052.GH44998@cdnetworks.co.kr> In-Reply-To: <20070612103820.GG44998@cdnetworks.co.kr> References: <200706120235.l5C2Z1iJ022543@repoman.freebsd.org> <20070612060521.D84335@grasshopper.cs.duke.edu> <20070612103820.GG44998@cdnetworks.co.kr>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jun 12, 2007 at 07:38:20PM +0900, To Andrew Gallatin wrote: > On Tue, Jun 12, 2007 at 06:05:21AM -0400, Andrew Gallatin wrote: > > Pyun YongHyeon [yongari@FreeBSD.org] wrote: > > > yongari 2007-06-12 02:35:01 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/dev/nfe if_nfe.c if_nfereg.h > > > Log: > > > Increase a maximum segment size of DMA to 4096. Previously it used > > > MCLBYTES for the segment size but it used too many Tx descriptors in > > > TSO case. > > > While I'm here adjust maximum size of the sum of all segment lengths > > > in a given DMA mapping to 65535, the maximum size, in bytes, of a IP > > > > Can't it actually be 65535 + link layer headers? Eg, up to > > 65535 + 14 or 65535 + 18? > > > > Oops, you're right. It should be 65535 + sizeof(struct ether_vlan_header). > Thanks for pointing out! :) > I've checked TSO enabled drivers in tree. It seems that the following drivers also have the same bug. CCed to maintainers. bce(4), cxgb(4) and em(4). -- Regards, Pyun YongHyeon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070612110052.GH44998>