Date: Sun, 31 Aug 2014 16:14:20 -0700 From: yaneurabeya@gmail.com To: Garrett Cooper <ngie@FreeBSD.org> Cc: "freebsd-testing@freebsd.org" <freebsd-testing@FreeBSD.org>, svn-src-all@freebsd.org, Julio Merino <jmmv@freebsd.org> Subject: Re: svn commit: r270905 - in stable/10: . contrib/atf contrib/atf/atf-c contrib/atf/atf-c++ contrib/atf/atf-sh etc/mtree lib/atf/libatf-c lib/atf/libatf-c++ lib/atf/libatf-c++/tests lib/atf/libatf-c/te... Message-ID: <6FAE3831-F98D-49E6-B919-67386FC1F986@gmail.com> In-Reply-To: <201408312309.s7VN9NuI026535@svn.freebsd.org> References: <201408312309.s7VN9NuI026535@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_5737E3B2-5CA8-47D7-8EF0-A208D5012416 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Aug 31, 2014, at 4:09 PM, Garrett Cooper <ngie@FreeBSD.org> wrote: > Author: ngie > Date: Sun Aug 31 23:09:23 2014 > New Revision: 270905 > URL: http://svnweb.freebsd.org/changeset/base/270905 >=20 > Log: > MFC r266650, r267172 (both by jmmv): >=20 > r266650: >=20 > Change libatf-c and libatf-c++ to be private libraries. >=20 > We should not be leaking these interfaces to the outside world = given > that it's much easier for third-party components to use the = devel/atf > package from ports. >=20 > As a side-effect, we can also drop the ATF pkgconfig and aclocal = files > from the base system. Nothing in the base system needs these, and = it > was quite ugly to have to get them installed only so that a few = ports > could build. The offending ports have been fixed to depend on > devel/atf explicitly. >=20 > Reviewed by: bapt >=20 > r267172: >=20 > Homogenize libatf-* version numbers with upstream. >=20 > The libatf-* major version numbers in FreeBSD were one version = ahead of > upstream because, when atf was first imported into FreeBSD, the = upstream > numbers were not respected. This is just confusing and bound to = cause > problems down the road. >=20 > Fix this by taking advantage of the fact that libatf-* are now = private > and that atf is not yet built by default. However, and = unfortunately, a > clean build is needed for tests to continue working once "make > delete-old-libs" has been run; hence the note in UPDATING. >=20 > Phabric: D701 > Approved by: jmmv (maintainer, mentor) Hi all, If you=92re running stable/10 after this point, please be sure = to run make delete-old-libs as described in UPDATING (prior to = installworld though IIRC). It=92s important because you might run into = runtime linking issues with the tests depending on which compiler you = use, which could cause false positives when run with kyua as the ATF = code. I=92m going to try and get out the MFC for r267181 out before = 10.1 is cut as well, which should make going between CURRENT and = 10-STABLE considerably easier with the test infrastructure. Thanks! -Garrett --Apple-Mail=_5737E3B2-5CA8-47D7-8EF0-A208D5012416 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJUA6xNAAoJEMZr5QU6S73exSoH/A6Isz48cE9TkGmzhE3JmGQS DA526u4LzaP9CadZYjR1pswBPP4y4xHWb0mznFmT3YWD91cC5qT+I4pR7Jm4ktug 4D5dz+lXLuolHx5dekkSXpra0jYup2UBODlw1IbQhRqmIU8hE7MtJGtLIEjoZpPg b3f8LohdSsGtT1qh4SBvKgKCw5snd5zxn/Ni+SQ7CJ8kw1d5p/DlElia+PFqB3YS e4ziKdoKUcKt7PJbefEVkC7mUAcOpO1UIrRDFQm3SOlBFtd0CB9LZCII/9iWBfZu K/tJFqThkejEwQ22SMutqGmPh0l4jahsWAK23/BaVbDkz5EPJ02/Znv1pZ4Bjpg= =Clkr -----END PGP SIGNATURE----- --Apple-Mail=_5737E3B2-5CA8-47D7-8EF0-A208D5012416--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6FAE3831-F98D-49E6-B919-67386FC1F986>