Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 26 Sep 2007 00:39:19 GMT
From:      Kip Macy <kmacy@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 126810 for review
Message-ID:  <200709260039.l8Q0dJKv015872@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=126810

Change 126810 by kmacy@kmacy_home:ethng_ref on 2007/09/26 00:38:43

	don't re-initialize m->m_pkthdr.len, it isn't needed and corrupts 
	mbuf data on non-pkthdr mbufs 

Affected files ...

.. //depot/projects/ethng/src/sys/dev/cxgb/sys/uipc_mvec.c#5 edit

Differences ...

==== //depot/projects/ethng/src/sys/dev/cxgb/sys/uipc_mvec.c#5 (text+ko) ====

@@ -221,10 +221,9 @@
 	for (i = 0; i < seg_count; i++) {
 		marray[i]->m_next = marray[i]->m_nextpkt = NULL;
 		if (marray[i]->m_flags & M_EXT) {
-			marray[i]->m_flags = marray[i]->m_len = marray[i]->m_pkthdr.len = 0;
+			marray[i]->m_flags = 0; 
 			m_free(marray[i]);
-		} else
-			marray[i]->m_len = marray[i]->m_pkthdr.len = 0;
+		} 
 	}
 	*nsegs = seg_count;
 	*m = m0;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200709260039.l8Q0dJKv015872>