Date: Thu, 26 Feb 2009 22:30:59 +0300 From: Stanislav Sedov <stas@FreeBSD.org> To: "Andrew W. Nosenko" <andrew.w.nosenko@gmail.com> Cc: Stanislav Sedov <stas@freebsd.org>, gnome@freebsd.org Subject: Re: [FreeBSD port]: devel/glib20 Message-ID: <20090226223059.9e23c3dc.stas@FreeBSD.org> In-Reply-To: <6161f3180902260653x2a6705l69b36c01b41caca0@mail.gmail.com> References: <20090224021026.ba40bdc2.stas@FreeBSD.org> <1235598615.3297.60.camel@shumai.marcuscom.com> <20090226171804.8681e79c.stas@FreeBSD.org> <6161f3180902260653x2a6705l69b36c01b41caca0@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Thu, 26 Feb 2009 16:53:16 +0200 "Andrew W. Nosenko" <andrew.w.nosenko@gmail.com> mentioned: > On Thu, Feb 26, 2009 at 4:18 PM, Stanislav Sedov <stas@freebsd.org> wrote: > > -----BEGIN PGP SIGNED MESSAGE----- > > Hash: SHA1 > > > > On Wed, 25 Feb 2009 16:50:15 -0500 > > Joe Marcus Clarke <marcus@marcuscom.com> mentioned: > > > >> On Tue, 2009-02-24 at 02:10 +0300, Stanislav Sedov wrote: > >> > -----BEGIN PGP SIGNED MESSAGE----- > >> > Hash: SHA1 > >> > > >> > Hi! > >> > > >> > glib20 has a known filename encoding problem with non-utf8 > >> > locales, because it doesn't perform names conversion from > >> > internal UTF8 to current locale by default (it used to do > >> > that some time ago). The patch included changes glib20 > >> > behaviour to always do the conversion (this will work > >> > for all non-UTF8 locales and will have no effect fot UTF8 > >> > ones). This is effectively the same redhat & co does in > >> > their deistributions. > >> > > >> > Comments? > >> > >> I have no objection, but I don't typically run into problems with > >> non-UTF-8 locales. I think it would be safer if you made this into an > >> OPTION, and added this as an extra patch if the OPTION is enabled. > >> > > > > Doesn't running gtk/glib (e.g. sylpheed, gimp) apps with non-UTF locale > > break filenames for you? From looking into the code it's always the case > > for non-UTF locales (well, if you running ISO8859-1 you shouldn't have > > problems too). On the other hand enabling LANG-based locale detection should > > not hurt prefromance much (I think the overhead of parsing LANG is neglible). > > Sure, we can OPTIONfy this, but I belive the options should be enabled by > > default in this case (otherwise, people will continue to step onto this > > bug). Major Linux distributions also have this option turned on by default > > to match the behavior of older version of glib where the locale detection > > code was always enabled. > > > > Why you want to patch Glib for turn this behavior on by default > instead of just install file in the /usr/local/etc/profile.d ? > > profile.d approrach is reversible (I can unset enviroment variable), > while patching Glib for remove patch ... slightly ugly at least, > IMHO. > Hmm, I didn't knew about this possible way. What kind of file should be installed here? Is it something specific to glib? Thanks! - -- Stanislav Sedov ST4096-RIPE -----BEGIN PGP SIGNATURE----- iEYEARECAAYFAkmm7fgACgkQK/VZk+smlYE//ACfZbbhjtyOsbI+HielwyDpEALF rK4An0nnpYEX3hHgEldusm2GpkHoMpn7 =2mrR -----END PGP SIGNATURE----- !DSPAM:49a6edef967002014410405!
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090226223059.9e23c3dc.stas>