Date: Wed, 21 Apr 2004 10:28:53 -0400 From: "Brian F. Feldman" <green@freebsd.org> To: Alexander Leidinger <Alexander@Leidinger.net> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/sound/pci cmi.c Message-ID: <200404211428.i3LESrYq042686@green.homeunix.org> In-Reply-To: Message from Alexander Leidinger <Alexander@Leidinger.net> <20040421135340.56f36568@Magellan.Leidinger.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Alexander Leidinger <Alexander@Leidinger.net> wrote: > On Tue, 20 Apr 2004 21:23:51 -0700 (PDT) > Brian Feldman <green@freebsd.org> wrote: > > > green 2004/04/20 21:23:51 PDT > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/sound/pci cmi.c > > Log: > > This driver certainly works fine turning INTR_MPSAFE back on. For those > > of you with other cards, please do review and test the drivers for > > MP-safety and disable Giant in the interrupt routines when you are > > sure of proper functionality. > > How to test it? Just mark it as MP-safe and play some audio? In this case, I reviewed the lock usage in the code to make sure that it protected the softc correctly, and to make sure I tested out all of the play and all of the record channels and the mixer at once. I don't think that there is really any more you could do than that, and luckily, the drivers are generally simple. -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200404211428.i3LESrYq042686>