Date: Sat, 9 Jan 2010 23:02:49 +0000 (UTC) From: Brooks Davis <brooks@FreeBSD.org> To: src-committers@freebsd.org, svn-src-projects@freebsd.org Subject: svn commit: r201944 - in projects/ngroups/sys: fs/procfs kern sys Message-ID: <201001092302.o09N2nEq041780@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: brooks Date: Sat Jan 9 23:02:49 2010 New Revision: 201944 URL: http://svn.freebsd.org/changeset/base/201944 Log: Improve a few comments. Modified: projects/ngroups/sys/fs/procfs/procfs_status.c projects/ngroups/sys/kern/subr_param.c projects/ngroups/sys/sys/socket.h Modified: projects/ngroups/sys/fs/procfs/procfs_status.c ============================================================================== --- projects/ngroups/sys/fs/procfs/procfs_status.c Sat Jan 9 23:02:14 2010 (r201943) +++ projects/ngroups/sys/fs/procfs/procfs_status.c Sat Jan 9 23:02:49 2010 (r201944) @@ -82,7 +82,7 @@ procfs_doprocstatus(PFS_FILL_ARGS) sid = sess->s_leader ? sess->s_leader->p_pid : 0; /* comm pid ppid pgid sid tty ctty,sldr start ut st wmsg - euid ruid rgid,egid,groups[1 ...] + euid ruid rgid,egid,groups[1 .. ngroups] */ pc = p->p_comm; Modified: projects/ngroups/sys/kern/subr_param.c ============================================================================== --- projects/ngroups/sys/kern/subr_param.c Sat Jan 9 23:02:14 2010 (r201943) +++ projects/ngroups/sys/kern/subr_param.c Sat Jan 9 23:02:49 2010 (r201944) @@ -231,8 +231,8 @@ init_param1(void) TUNABLE_ULONG_FETCH("kern.sgrowsiz", &sgrowsiz); /* - * Let the user set ngroups_max, but don't let it go below - * NGROUPS_MAX which would violate POSIX.1-2008. + * Let the administrator set {NGROUPS_MAX}, but disallow values + * less than NGROUPS_MAX which would violate POSIX.1-2008. */ ngroups_max = NGROUPS_MAX; TUNABLE_INT_FETCH("kern.ngroups", &ngroups_max); Modified: projects/ngroups/sys/sys/socket.h ============================================================================== --- projects/ngroups/sys/sys/socket.h Sat Jan 9 23:02:14 2010 (r201943) +++ projects/ngroups/sys/sys/socket.h Sat Jan 9 23:02:49 2010 (r201944) @@ -462,7 +462,8 @@ struct cmsghdr { #if __BSD_VISIBLE /* * While we may have more groups than this, the cmsgcred struct must - * be able to fit in an mbuf. + * be able to fit in an mbuf and we have historically supported a + * maximum of 16 groups. */ #define CMGROUP_MAX 16
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201001092302.o09N2nEq041780>