Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 29 Oct 2001 09:27:01 -0800 (PST)
From:      John Baldwin <jhb@FreeBSD.org>
To:        Doug Rabson <dfr@nlsystems.com>
Cc:        cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org
Subject:   Re: cvs commit: src/sys/alpha/alpha trap.c src/sys/i386/i386 tra
Message-ID:  <XFMail.011029092701.jhb@FreeBSD.org>
In-Reply-To: <Pine.BSF.4.33.0110291459200.41783-100000@herring.nlsystems.com>

next in thread | previous in thread | raw e-mail | index | archive | help

On 29-Oct-01 Doug Rabson wrote:
> On Fri, 26 Oct 2001, John Baldwin wrote:
> 
>> jhb         2001/10/26 01:12:54 PDT
>>
>>   Modified files:
>>     sys/alpha/alpha      trap.c
>>     sys/i386/i386        trap.c
>>     sys/ia64/ia64        trap.c
>>     sys/kern             init_main.c kern_exit.c kern_fork.c
>>                          subr_trap.c
>>     sys/sparc64/sparc64  trap.c
>>     sys/sys              proc.h
>>   Log:
>>   Add a per-thread ucred reference for syscalls and synchronous traps from
>>   userland.  The per thread ucred reference is immutable and thus needs no
>>   locks to be read.  However, until all the proc locking associated with
>>   writes to p_ucred are completed, it is still not safe to use the
>>   per-thread
>>   reference.
>>
>>   Tested on: x86 (SMP), alpha, sparc64
> 
> This gets horribly confused when I set a DDB breakpoint at the start of
> syscall() - it goes into a tight look calling panic because the value of
> td_ucred is NULL.

Hmm, ok.  I'll change the KASSERT() to not fail for kernel trace and breakpoint
traps, or something along those lines.

-- 

John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/
PGP Key: http://www.baldwin.cx/~john/pgpkey.asc
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.011029092701.jhb>